From 09b2f307bcc96f1cc2952c44cdd1c9e30c93c699 Mon Sep 17 00:00:00 2001
From: Are Almaas <arealmaas@gmail.com>
Date: Thu, 8 Feb 2024 10:15:33 +0100
Subject: [PATCH] fix: shorten secret name for container app job (#422)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`Secret names cannot be longer than 20. Please shorten
dialogdbconnectionstringsecreturi`

🤷
---
 .azure/modules/containerAppJob/main.bicep | 4 ++--
 .github/tools/README.md                   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.azure/modules/containerAppJob/main.bicep b/.azure/modules/containerAppJob/main.bicep
index 9b05cb8a5..8b5c9ccfe 100644
--- a/.azure/modules/containerAppJob/main.bicep
+++ b/.azure/modules/containerAppJob/main.bicep
@@ -16,7 +16,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
       secrets: [
         {
           // todo: move this and refactor into adding this somewhere else
-          name: 'dialogdbconnectionstringsecreturi'
+          name: 'dbconnectionstring'
           keyVaultUrl: adoConnectionStringSecretUri
           identity: 'System'
         }
@@ -36,7 +36,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
           env: [
             {
               name: 'Infrastructure__DialogDbConnectionString'
-              secretRef: 'dialogdbconnectionstringsecreturi'
+              secretRef: 'dbconnectionstring'
             }
           ]
           image: image
diff --git a/.github/tools/README.md b/.github/tools/README.md
index bd130874a..aba0d4b6a 100644
--- a/.github/tools/README.md
+++ b/.github/tools/README.md
@@ -1,6 +1,6 @@
 # Tools
 
-`.github/tools/containerAppJobVerifier.sh` is used to verify the status of a container application job. It checks if the job has completed successfully or not.
+`.github/tools/containerAppJobVerifier.sh` is used to verify the status of a container application job. It checks if the job has completed successfully or not
 
 `.github/tools/pwdGenerator.ps1` is used to generate passwords.