Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow function replacement for string replace #82

Closed
MM25Zamanian opened this issue Mar 11, 2022 · 6 comments · Fixed by #91
Closed

Arrow function replacement for string replace #82

MM25Zamanian opened this issue Mar 11, 2022 · 6 comments · Fixed by #91
Assignees
@alimd
Labels
enhancement Enhancement of the code, not introducing new features.
Milestone
v0.x

Comments

@MM25Zamanian
Copy link
Contributor

Wouldn't it be better to use the arrow functions here?
@alimd
Copy link
Member

alimd commented Mar 11, 2022

Which line exactly?!
All functions are arrow!

@alimd
Copy link
Member

alimd commented Mar 11, 2022 •
edited
Loading

در ضمن این چه تایپی از ایشو هستش؟!
لطفا اگر ایشو (مشکل) نیست دیسکاشن باز کن

@Alwatr Alwatr locked and limited conversation to collaborators Mar 11, 2022
@MM25Zamanian MM25Zamanian converted this issue into a discussion Mar 11, 2022
@alimd alimd reopened this Mar 11, 2022
@alimd
Copy link
Member

alimd commented Mar 11, 2022

الان دیسکاشنی که تبدیل کردی کجاست؟
بعد تبدیل پاکش کردی؟ 😆

@alimd
Copy link
Member

alimd commented Mar 11, 2022

من متوجه اینکه چطور باید اونجا arrow باشه نمیشم کد نمونه بده
ولی جدا از این بحث چرا هر دفعه داره replace میشه! لطفا قبل return یک بریز تو متغییر styleScope و داخل ازش استفاده کن
مرسی

@MM25Zamanian
Copy link
Contributor Author

الان دیسکاشنی که تبدیل کردی کجاست؟
بعد تبدیل پاکش کردی؟ 😆

من اشتباه کرده بودم

@MM25Zamanian
Copy link
Contributor Author

واسه همین پاکش کردم ولی قبلش به دیسکاشن تبدیل کردم

@alimd alimd added enhancement Enhancement of the code, not introducing new features. and removed Off Topic labels Mar 11, 2022
@alimd alimd added this to the v1.0.0-beta milestone Mar 11, 2022
@alimd alimd self-assigned this Mar 11, 2022
@alimd alimd closed this as completed in #91 Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alimd alimd

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging a pull request may close this issue.

perf(logger): refactor making logger object Alwatr/alwatr
2 participants
@alimd @MM25Zamanian