Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default specs filename on sdk generation #1807

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: default specs filename on sdk generation #1807

merged 1 commit into from
Jun 4, 2024

Conversation

mrednic-1A
Copy link
Contributor

@mrednic-1A mrednic-1A requested a review from a team as a code owner May 21, 2024 14:36
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 21, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab9d9e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@github-actions github-actions bot added bug Something isn't working project:@ama-sdk/create labels May 21, 2024
vscaiceanu-1a
vscaiceanu-1a previously approved these changes May 21, 2024
View reviewed changes
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from c2670ff to 79c67a7 Compare May 22, 2024 10:33
@mrednic-1A mrednic-1A changed the title fix: add dynamic extension for specs file name at sdk create [DRAFT] fix: add dynamic extension for specs file name at sdk create May 22, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch 3 times, most recently from c6fadcc to 38a6742 Compare May 22, 2024 13:29
@mrednic-1A mrednic-1A changed the title [DRAFT] fix: add dynamic extension for specs file name at sdk create [DRAFT] fix: default specs filename on sdk generation; publish showcase specs May 23, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 38a6742 to 8ea051a Compare May 23, 2024 08:39
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch 4 times, most recently from 3a22d9b to e735659 Compare May 23, 2024 12:56
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from e735659 to 407907f Compare May 23, 2024 12:59
@mrednic-1A mrednic-1A changed the title [DRAFT] fix: default specs filename on sdk generation; publish showcase specs fix: default specs filename on sdk generation; publish showcase specs May 23, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 407907f to bc5f04a Compare May 23, 2024 14:21
kpanot
kpanot reviewed May 23, 2024
View reviewed changes
packages/@ama-sdk/schematics/schematics/typescript/core/index.ts Show resolved Hide resolved
packages/@ama-sdk/core/src/utils/generators.ts Outdated Show resolved Hide resolved
packages/@ama-sdk/core/src/utils/generators.ts Outdated Show resolved Hide resolved
packages/@ama-sdk/create/src/index.ts Outdated Show resolved Hide resolved
packages/@ama-sdk/create/src/index.ts Outdated Show resolved Hide resolved
@mrednic-1A mrednic-1A changed the title fix: default specs filename on sdk generation; publish showcase specs fix: default specs filename on sdk generation May 24, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch 2 times, most recently from 58dd912 to f09b9a6 Compare May 27, 2024 12:46
@mrednic-1A mrednic-1A changed the title fix: default specs filename on sdk generation draft fix: default specs filename on sdk generation May 27, 2024
@mrednic-1A mrednic-1A changed the title draft fix: default specs filename on sdk generation [draft] fix: default specs filename on sdk generation May 27, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch 2 times, most recently from f6268a5 to 33636da Compare May 27, 2024 18:53
@mrednic-1A mrednic-1A changed the title [draft] fix: default specs filename on sdk generation fix: default specs filename on sdk generation May 27, 2024
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 33636da to 957af53 Compare May 28, 2024 07:25
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 957af53 to 5ea1ed8 Compare May 29, 2024 09:31
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch 2 times, most recently from c79053d to f854640 Compare May 29, 2024 18:01
@mrednic-1A mrednic-1A changed the base branch from main to release/10.4.0-rc May 29, 2024 18:02
kpanot
kpanot reviewed May 30, 2024
View reviewed changes
packages/@ama-sdk/core/cli/update-spec-from-npm.cts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this CLI should be moved to the @ama-sdk/schematics as part of the sdk generator and to include generator specific constants to a package used as prod dep.
(same remark for the other CLIs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this. Here is the issue opened for next major #1843.

packages/@ama-sdk/core/cli/update-spec-from-npm.cts Outdated Show resolved Hide resolved
packages/@ama-sdk/core/cli/update-spec-from-npm.cts Outdated Show resolved Hide resolved
packages/@ama-sdk/create/src/index.ts Outdated Show resolved Hide resolved
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from f854640 to 9eb2ed0 Compare May 30, 2024 08:28
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 9eb2ed0 to 2136277 Compare June 3, 2024 11:36
@mrednic-1A mrednic-1A force-pushed the fix/extension-for-default-specs branch from 2136277 to ab9d9e7 Compare June 4, 2024 08:13
@mrednic-1A mrednic-1A enabled auto-merge June 4, 2024 08:13
@mrednic-1A mrednic-1A merged commit 7798d7c into release/10.4.0-rc Jun 4, 2024
26 of 27 checks passed
@mrednic-1A mrednic-1A deleted the fix/extension-for-default-specs branch June 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscaiceanu-1a vscaiceanu-1a vscaiceanu-1a left review comments

@kpanot kpanot kpanot approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@sdo-1A sdo-1A sdo-1A approved these changes

Assignees
No one assigned
Labels
bug Something isn't working project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/showcase-sdk project:@ama-sdk/swagger-builder project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Create an sdk from specs from an npm module fails when specs file extension is not '.yml'
5 participants
@mrednic-1A @kpanot @vscaiceanu-1a @fpaul-1A @sdo-1A