Implement Support for creating the locking primitives in a const context on stable Rust #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new constructor allows creating mutexes, reentrant mutexes and RwLocks in a constant context on stable Rust by manually passing in the underlying raw mutex / rwlock.
This adds various helper functions to `parking_lot` that allow creating parking_lot's mutexes, reentrant mutexes, fair mutexes and RwLocks in constant contexts on stable Rust.
|
This is a rough initial implementation. I'm not sure if the helpers in |
Amanieu
requested changes
Feb 18, 2020
There was a problem hiding this comment.
Can you make two changes:
- Put
This allows creating a mutex in a constant context on stable Rust.as a separate paragraph in the doc comments. This keeps the first line as a short summary of what the function actually does. - Rename the functions from
new_*toconst_*to make it clear that they are mainly useful for const initializers.
This splits the doc comments into multiple paragraphs and renames the helpers to create the locking primitives to `const_*` instead of `new_*`.
Amanieu
approved these changes
Feb 19, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2020
217: Implement Support for creating the locking primitives in a const context on stable Rust r=Amanieu a=CryZe This adds a new constructor `const_new` to lock_api's mutexes, reentrant mutexes and RwLocks that allows creating them in a constant context on stable Rust by manually passing in the underlying raw mutex / rwlock. Additionally, various helper functions are being added to parking_lot that allow creating mutexes, reentrant mutexes, fair mutexes and RwLocks in constant contexts on stable Rust. Co-authored-by: Christopher Serr <christopher.serr@gmail.com>
|
Any chance this could get cut in a release? I could probably deprecate https://crates.io/crates/static_locks if it were. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new constructor
const_newto lock_api's mutexes, reentrant mutexes and RwLocks that allows creating them in a constant context on stable Rust by manually passing in the underlying raw mutex / rwlock.Additionally, various helper functions are being added to parking_lot that allow creating mutexes, reentrant mutexes, fair mutexes and RwLocks in constant contexts on stable Rust.