Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for two Miri issues with unit tests #252

Merged
merged 3 commits into from
Oct 3, 2020

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Oct 3, 2020

Fixes #251

With this change, all parking_lot tests pass with Miri with rust-lang/miri#1568 applied, except for the webkit_queue_tests which are too slow to complete in reasonable time with Miri. (Lowering the number of messages per producer to 100 or 10 makes them pass too.)

@m-ou-se
Copy link
Contributor Author

m-ou-se commented Oct 3, 2020

The failing test is unrelated:

error: component 'rust-std' for target 'x86_64-unknown-cloudabi' is unavailable for download for channel nightly

rust-std for CloudABI is no longer distributed by rustup. (rust-lang/rust#75568)

@Amanieu
Copy link
Owner

Amanieu commented Oct 3, 2020

Just remove cloudabi from .travis.yml

Cloudabi is no longer available from rustup, as it has been moved to
tier 3.
@Amanieu
Copy link
Owner

Amanieu commented Oct 3, 2020

@bors r+

@Amanieu
Copy link
Owner

Amanieu commented Oct 3, 2020

Oh wait there's no bors here.

@Amanieu Amanieu merged commit 5ac2971 into Amanieu:master Oct 3, 2020
@m-ou-se m-ou-se deleted the miri-issues branch January 17, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two minor Miri issues with unit tests
2 participants