Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate lessons into Japanese from lesson 21 in Solidity 102 #736

Merged
merged 33 commits into from
Aug 3, 2024
Merged

Translate lessons into Japanese from lesson 21 in Solidity 102 #736

merged 33 commits into from
Aug 3, 2024

Conversation

thurendous
Copy link
Contributor

@thurendous thurendous commented Jun 1, 2024 •
edited
Loading

What type of PR is this (这是什么类型的PR)

  • Typo(勘误)
  • BUG(程序错误)
  • Improvement(提升)
  • Feature(新特性)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

  • resolve(修复) : #

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

Add Solidity lessons in Japanese.

  • 21
  • 22
  • 23
  • 24
  • 25
  • 26
  • 27
  • 28
  • 29
  • 30
  • translating images into ja

@thurendous thurendous changed the title translate lesson 21 into Japanese translate lessons into Japanese from lesson 21 Jun 3, 2024
@thurendous thurendous changed the title translate lessons into Japanese from lesson 21 Translate lessons into Japanese from lesson 21 on Solidity 102 Jun 3, 2024
@thurendous thurendous changed the title Translate lessons into Japanese from lesson 21 on Solidity 102 Translate lessons into Japanese from lesson 21 in Solidity 102 Jun 3, 2024
@thurendous
Copy link
Contributor Author

This is still a work in progress.

@thurendous
Copy link
Contributor Author

thurendous commented Jul 6, 2024 •
edited
Loading

Lesson 26 and 27 pushed. Please check them for me. @PolymetisOutis

@PolymetisOutis
Copy link
Contributor

@thurendous kk

PolymetisOutis
PolymetisOutis approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@PolymetisOutis PolymetisOutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントを入れたよ！

Languages/ja/27_ABIEncode_ja/img/27-1.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
これは後回しにせずなんとかならない？画像日本語版にしようよ
終わったら、コメントのタイムライン末尾に"完了"とチェックマーク✅をよろしく！

Languages/ja/27_ABIEncode_ja/img/27-2.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
これは後回しにせずなんとかならない？画像日本語版にしようよ
終わったら、コメントのタイムライン末尾に"完了"とチェックマーク✅をよろしく！

Languages/ja/27_ABIEncode_ja/img/27-3.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
これは後回しにせずなんとかならない？画像日本語版にしようよ
終わったら、コメントのタイムライン末尾に"完了"とチェックマーク✅をよろしく！

Languages/ja/27_ABIEncode_ja/readme.md Outdated Show resolved Hide resolved
Languages/ja/26_DeleteContract_ja/img/26-1.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
これは後回しにせずなんとかならない？画像日本語版にしようよ
終わったら、コメントのタイムライン末尾に"完了"とチェックマーク✅をよろしく！

Languages/ja/23_Delegatecall_ja/img/23-5.png Outdated Show resolved Hide resolved
Languages/ja/23_Delegatecall_ja/img/23-6.png Outdated Show resolved Hide resolved
Languages/ja/23_Delegatecall_ja/img/23-7.png Outdated Show resolved Hide resolved
Languages/ja/23_Delegatecall_ja/readme.md Outdated Show resolved Hide resolved
Languages/ja/24_Create/img/24-1.png Outdated Show resolved Hide resolved
@thurendous
Copy link
Contributor Author

I've finished all the lessons for now except for the images. Please check for me. @PolymetisOutis

@PolymetisOutis PolymetisOutis mentioned this pull request Jul 20, 2024
Merged
4 tasks
PolymetisOutis
PolymetisOutis reviewed Jul 28, 2024
View reviewed changes
Copy link
Contributor

@PolymetisOutis PolymetisOutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
中文が紛れ込んでいたよ！！

Languages/ja/29_Selector_ja/readme.md Outdated Show resolved Hide resolved
Languages/ja/29_Selector_ja/readme.md Outdated Show resolved Hide resolved
PolymetisOutis
PolymetisOutis reviewed Jul 28, 2024
View reviewed changes
Copy link
Contributor

@PolymetisOutis PolymetisOutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
中文が紛れ込んでいるよ！！

Languages/ja/24_Create/readme.md Outdated Show resolved Hide resolved
PolymetisOutis
PolymetisOutis reviewed Jul 28, 2024
View reviewed changes
Copy link
Contributor

@PolymetisOutis PolymetisOutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thurendous
中文が紛れ込んでいるよ！！

Languages/ja/22_Call/readme.md Outdated Show resolved Hide resolved
@AmazingAng AmazingAng marked this pull request as ready for review July 31, 2024 12:57
@AmazingAng
Copy link
Owner

Is this pr ready to merge?

@AmazingAng AmazingAng merged commit f4e86eb into AmazingAng:main Aug 3, 2024
1 check failed
@thurendous
Copy link
Contributor Author

Thanks for merging the branch. @AmazingAng
Thanks for the reviews. @PolymetisOutis

@thurendous thurendous deleted the add-japanese-lessons-since-lesson-21 branch August 25, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PolymetisOutis PolymetisOutis PolymetisOutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thurendous @PolymetisOutis @AmazingAng