Wtf ja 101 01 #737

PolymetisOutis · 2024-06-02T10:49:21Z

What type of PR is this (这是什么类型的PR)

Typo(勘误)
BUG(程序错误)
Improvement(提升)
Feature(新特性)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

resolve(修复) : #

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

PolymetisOutis · 2024-06-02T10:53:01Z

Hi, I am trying to add Japanese version with @thurendous , and now I want to make a pull request about
just 101-01_HelloWeb3_ja as a test.

thurendous · 2024-06-03T08:44:37Z

We are working together on this now. Thanks! @PolymetisOutis
I am working on Solidity 102 and he is on Solidity 101.

AmazingAng · 2024-06-07T17:07:59Z

lfg！

PolymetisOutis · 2024-06-09T12:24:30Z

May I have a talk a bit?? @AmazingAng
https://www.wtf.academy/docs/solidity-101/HelloWeb3/
In this page, I think "第二个条件由^提供" must be "第一个条件由^提供", i.e. "the first condition is provided by ^".
Through some discussion with @thurendous , it comes to end in my misunderstanding, but in my opinion about reading comprehension I think still it's appropriate that "first condition" means "more than v0.8.4" and "second condition" means "less than v0.9.0" in the following sentence, i.e. v0.8.4 ≦ version < v0.9.0:"The second line declares the Solidity version used by the source file, because the syntax of different versions is different. This line of code means that the source file will not allow compilation by compilers version lower than v0.8.4 and not higher than v0.9.0"
So, I want to recommend "first condition" may fit. How about that?

AmazingAng · 2024-06-23T09:30:43Z

are they ready for merge?

AmazingAng · 2024-06-23T09:34:45Z

May I have a talk a bit?? @AmazingAng https://www.wtf.academy/docs/solidity-101/HelloWeb3/ In this page, I think "第二个条件由^提供" must be "第一个条件由^提供", i.e. "the first condition is provided by ^". Through some discussion with @thurendous , it comes to end in my misunderstanding, but in my opinion about reading comprehension I think still it's appropriate that "first condition" means "more than v0.8.4" and "second condition" means "less than v0.9.0" in the following sentence, i.e. v0.8.4 ≦ version < v0.9.0:"The second line declares the Solidity version used by the source file, because the syntax of different versions is different. This line of code means that the source file will not allow compilation by compilers version lower than v0.8.4 and not higher than v0.9.0" So, I want to recommend "first condition" may fit. How about that?

I think you are right. ^ symbol in Solidity indicates compatibility with the specified version and any higher versions, but not including the next major version.

Also, the contents on wtf.academy website may not be the most updated version, please refer to GitHub repo when translating. Thank you!

PolymetisOutis · 2024-06-23T12:46:38Z

@AmazingAng
Thank you for your reply! :D

I think you are right.

OK, thank you so much,
I’ve already reflected it to the latest PR version.

Also, the contents on wtf.academy website may not be the most updated version, please refer to GitHub repo when translating.

OK, I've also checked them.

are they ready for merge?

Yeah, so sure, I'm ready!
Please merge, let's get started!! CC:@thurendous

PolymetisOutis · 2024-06-23T12:51:58Z

now I am working in progress about 101-06 to 101-08. Only 8-1 and 8-2 png picture editting left. :▷
CC: @thurendous

PolymetisOutis · 2024-06-24T11:35:21Z

@AmazingAng
Now PR commit of 101-06 to 101-08 lecture has been done!!
Please note that some explanations are added to the each article in some places for beginner's guide to understand the meaning of the expressions!!
best regards, CC: @thurendous

PolymetisOutis · 2024-06-30T07:44:58Z

@AmazingAng CC: @thurendous
Now, 101-09 to 101-11 lecture ja version added!!
Thanks for everything!! :D

AmazingAng · 2024-06-30T11:31:16Z

@AmazingAng CC: @thurendous Now, 101-09 to 101-11 lecture ja version added!! Thanks for everything!! :D

wow, this is great!
Shall I merge it?

PolymetisOutis · 2024-07-05T11:35:53Z

@AmazingAng CC: @thurendous
Sure, of course!! Please merge it all !!

thurendous

I've added some comments (WIP) @PolymetisOutis

Languages/ja/02_ValueTypes_ja/readme.md

Languages/ja/03_Function_ja/Function.sol

Languages/ja/02_ValueTypes_ja/ValueTypes.sol

thurendous

I've added some comments (done) @PolymetisOutis

Languages/ja/02_ValueTypes_ja/img/2-2.png

Languages/ja/03_Function_ja/readme.md

thurendous · 2024-07-06T02:11:36Z

Languages/ja/05_DataStorage_ja/DataStorage.sol

+
+        function foo() external{
+            // You can change the value of the state variable in the function
+            // （関数内で状態変数の値を変えることができます）


この様式も統一する必要がありそうだね、、日本語のみにしてました。

なんか二人共通の翻訳のルールを作ったほうがよいのかな

@thurendous
呉さん、ここは、英語が入っていた方が良いと判断して、敢えて英文はそのままにしたのだ
日本語の初学者は英語に触れる機会が多い筈だからね

出来れば、こちらに寄せて統一してくれないかな？
英語版のリポジトリから貼ってくれると助かる。

終わったら、"DONE"
の連絡ちょうだい！！

そうだね。こっちのほうがきれいな気がしたな、、

Languages/ja/05_DataStorage_ja/readme.md

Languages/ja/06_ArrayAndStruct_ja/readme.md

PolymetisOutis · 2024-07-06T08:47:18Z

@thurendous CC: @AmazingAng
コメントどうもありがとう🙇‍♂️
一つ一つ対応させてください🙌
終わったら、「完了✅」のメッセージを入れて、"Resolved"にします！

Thanks for your comments🙇‍♂️
Let me deal with them one by one.🙌
When finished, insert the message "Done✅" and set it to "Resolved"!

PolymetisOutis · 2024-07-07T08:20:13Z

@thurendous CC: @AmazingAng
これからPRで貰ったコメントについて集約し、次の項目について実施する
I will apply the following items given in the comments

1 Summaryの翻訳を「まとめ」に統一
2 ソースコードのコメントを和訳
　Lecture2
　Lecture3
　Lecture4
　Lecture6
　Lecture10
3 Lecture3 readme.md 絵文字を入れるｗ
4 Lecture5 readme.md memoryの項目の英訳が抜けていた箇所を挿入
5 Lecture5 readme.md 項目4が英訳に無かったので中文に倣って挿入

AmazingAng · 2024-07-13T06:33:02Z

lgtm, ready to merge!

PolymetisOutis · 2024-07-20T12:26:33Z

@thurendous CC: @AmazingAng
これからPRで貰ったコメントについて集約し、次の項目について実施する
I will apply the following items given in the comments

1 Summaryの翻訳を「まとめ」に統一　→　DONE✅
2 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture2
　Lecture3
　Lecture4
　Lecture6
　Lecture10
3 Lecture3 readme.md 絵文字を入れるｗ　→　DONE✅
4 Lecture5 readme.md memoryの項目の英訳が抜けていた箇所を挿入　→　未UNDONE
5 Lecture5 readme.md 項目4が英訳に無かったので中文に倣って挿入　→　未UNDONE

PolymetisOutis · 2024-07-20T12:33:04Z

@AmazingAng CC: @thurendous
Thank you very much for merging this PR!!
Excuse me, but some 101 lecture is still being translated and gonna be modified by me :D !!
I think this PR must be opened!! now closed tho!!
Like this PR #736
is still open!!

AmazingAng · 2024-07-20T13:10:05Z

@AmazingAng CC: @thurendous
Thank you very much for merging this PR!!
Excuse me, but some 101 lecture is still being translated and gonna be modified by me :D !!
I think this PR must be opened!! now closed tho!!
Like this PR #736
is still open!!

I see, this pr not closed but merged into main branch. If you want to modify, please open a new pr for it. sorry for the inconvenience.

PolymetisOutis · 2024-07-21T10:43:06Z

@AmazingAng CC: @thurendous
Your rapid response is much appreciated.
Thanks for merging this PR into main branch.
I got it. I will try to open a new PR!!

PolymetisOutis · 2024-07-27T10:55:06Z

@thurendous CC: @AmazingAng
Work in progress!!（4/9）
New PR ⇒ #767

1 Summaryの翻訳を「まとめ」に統一　→　DONE✅
2 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture2
3 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture3
4 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture4
5 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture6
6 ソースコードのコメントを和訳　　　→　未UNDONE
　Lecture10
7 Lecture3 readme.md 絵文字を入れるｗ　→　DONE✅
8 Lecture5 readme.md memoryの項目の英訳が抜けていた箇所を挿入　→　DONE✅
9 Lecture5 readme.md 項目4が英訳に無かったので中文に倣って挿入　→　DONE✅

PolymetisOutis · 2024-07-27T11:31:23Z

@thurendous CC: @AmazingAng
Work in progress!!（9/9）
https://github.com/PolymetisOutis/WTF-Solidity/tree/WTF_ja_101_1_11_modify/Languages/ja
New PR ⇒ #767

1 Summaryの翻訳を「まとめ」に統一　→　DONE✅
2 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture2
3 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture3
4 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture4
5 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture6
6 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture10
7 Lecture3 readme.md 絵文字を入れるｗ　→　DONE✅
8 Lecture5 readme.md memoryの項目の英訳が抜けていた箇所を挿入　→　DONE✅
9 Lecture5 readme.md 項目4が英訳に無かったので中文に倣って挿入　→　DONE✅

以上、
よろしくお願いいたします。
完了です！！✅

ALL DONE✅（All points raised in the comments have been addressed🫡😊🙌 Thanks A LOT 🙏.）

AmazingAng · 2024-07-27T11:59:26Z

@thurendous CC: @AmazingAng
Work in progress!!（4/9）
https://github.com/PolymetisOutis/WTF-Solidity/tree/WTF_ja_101_1_11_modify/Languages/ja
New PR ⇒ #767

1 Summaryの翻訳を「まとめ」に統一　→　DONE✅
2 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture2
3 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture3
4 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture4
5 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture6
6 ソースコードのコメントを和訳　　　→　DONE✅
　Lecture10
7 Lecture3 readme.md 絵文字を入れるｗ　→　DONE✅
8 Lecture5 readme.md memoryの項目の英訳が抜けていた箇所を挿入　→　DONE✅
9 Lecture5 readme.md 項目4が英訳に無かったので中文に倣って挿入　→　DONE✅

以上、
よろしくお願いいたします。
完了です！！✅

ALL DONE✅（All points raised in the comments have been addressed🫡😊🙌 Thanks A LOT 🙏.）

wow, this is amazing!

thurendous · 2024-07-27T14:06:42Z

@PolymetisOutis Great work! Thanks for the contributions!

PolymetisOutis · 2024-07-28T05:11:14Z

@AmazingAng CC: @thurendous
Once again, all points raised in the comments have been addressed.
ALL FINISHED.👍‼️🙌
New PR ⇒ #767

PolymetisOutis · 2024-07-28T05:15:07Z

@thurendous CC: @AmazingAng
ソースコードについて全ての日本語訳を実装しました‼️👍
ご指摘ありがとう🙌✨✨✨基本的にはご指摘頂いた内容はALL RESOLVEDだ！！
In detail, Japanese translation of comments has been implemented in the source code.
Thank you for pointing this out.😎👍✨
Basically, all points you pointed out are RESOLVED!!✅

PolymetisOutis added 12 commits May 12, 2024 21:42

first commit

d05ec87

second commit main

e46b06b

first commit to WTF_ja_101_01

8937631

first lesson commit

4c8afff

PICTURE modified and others

2210ba4

pictures size modified

6da88e5

pictures size re-modified

3d652ce

delete pictures temporarily

d5e6c45

delete html

00e6b60

pictures resized replaced

3e72d43

change folder name _en to _ja

787bf77

02-15 en version erased

00db220

PolymetisOutis added 9 commits June 15, 2024 21:25

02 and 03 addedgit add .

07ed73a

01 second condition translation changed

e793637

101 title modified

180183e

101 title modified japanese

327de78

04-05 added!

bde9d34

5-4.png size modified

9c4a1f9

04-05 Folder name _en to _ja rename

e94a88b

05 picture replaced

90fae6d

5-4.png Example label indent

0db731e

06-08 added

5bfdfdf

PolymetisOutis added 2 commits June 24, 2024 20:25

07-08 png _ja added modification

8174edb

08 picture change jpg to png

f8d2ae4

101-09 to 101-11 added, and subtle modification

e49fb01

control flow title translation added

505eeb3

thurendous reviewed Jul 6, 2024

View reviewed changes

Languages/ja/02_ValueTypes_ja/readme.md Show resolved Hide resolved

Languages/ja/02_ValueTypes_ja/readme.md Outdated Show resolved Hide resolved

Languages/ja/03_Function_ja/Function.sol Show resolved Hide resolved

Languages/ja/02_ValueTypes_ja/ValueTypes.sol Show resolved Hide resolved

thurendous reviewed Jul 6, 2024

View reviewed changes

PolymetisOutis added 3 commits July 7, 2024 17:24

'Summary' translation all changed and unified

06301ca

'Summary' translation all changed and unified

f08bcd6

Lecture3 moji added from chinese version

566cccf

AmazingAng merged commit 5768a98 into AmazingAng:main Jul 13, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wtf ja 101 01 #737

Wtf ja 101 01 #737

PolymetisOutis commented Jun 2, 2024 •

edited

Loading

PolymetisOutis commented Jun 2, 2024

thurendous commented Jun 3, 2024

AmazingAng commented Jun 7, 2024

PolymetisOutis commented Jun 9, 2024

AmazingAng commented Jun 23, 2024

AmazingAng commented Jun 23, 2024

PolymetisOutis commented Jun 23, 2024 •

edited

Loading

PolymetisOutis commented Jun 23, 2024 •

edited

Loading

PolymetisOutis commented Jun 24, 2024

PolymetisOutis commented Jun 30, 2024

AmazingAng commented Jun 30, 2024

PolymetisOutis commented Jul 5, 2024 •

edited

Loading

thurendous left a comment

thurendous left a comment •

edited

Loading

thurendous Jul 6, 2024

thurendous Jul 6, 2024

PolymetisOutis Jul 6, 2024 •

edited

Loading

thurendous Jul 6, 2024

PolymetisOutis commented Jul 6, 2024 •

edited

Loading

PolymetisOutis commented Jul 7, 2024 •

edited

Loading

AmazingAng commented Jul 13, 2024

PolymetisOutis commented Jul 20, 2024

PolymetisOutis commented Jul 20, 2024 •

edited

Loading

AmazingAng commented Jul 20, 2024

PolymetisOutis commented Jul 21, 2024

PolymetisOutis commented Jul 27, 2024 •

edited

Loading

PolymetisOutis commented Jul 27, 2024 •

edited

Loading

AmazingAng commented Jul 27, 2024

thurendous commented Jul 27, 2024

PolymetisOutis commented Jul 28, 2024

PolymetisOutis commented Jul 28, 2024 •

edited

Loading

Wtf ja 101 01 #737

Wtf ja 101 01 #737

Conversation

PolymetisOutis commented Jun 2, 2024 • edited Loading

What type of PR is this (这是什么类型的PR)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

PolymetisOutis commented Jun 2, 2024

thurendous commented Jun 3, 2024

AmazingAng commented Jun 7, 2024

PolymetisOutis commented Jun 9, 2024

AmazingAng commented Jun 23, 2024

AmazingAng commented Jun 23, 2024

PolymetisOutis commented Jun 23, 2024 • edited Loading

PolymetisOutis commented Jun 23, 2024 • edited Loading

PolymetisOutis commented Jun 24, 2024

PolymetisOutis commented Jun 30, 2024

AmazingAng commented Jun 30, 2024

PolymetisOutis commented Jul 5, 2024 • edited Loading

thurendous left a comment

Choose a reason for hiding this comment

thurendous left a comment • edited Loading

Choose a reason for hiding this comment

thurendous Jul 6, 2024

Choose a reason for hiding this comment

thurendous Jul 6, 2024

Choose a reason for hiding this comment

PolymetisOutis Jul 6, 2024 • edited Loading

Choose a reason for hiding this comment

thurendous Jul 6, 2024

Choose a reason for hiding this comment

PolymetisOutis commented Jul 6, 2024 • edited Loading

PolymetisOutis commented Jul 7, 2024 • edited Loading

AmazingAng commented Jul 13, 2024

PolymetisOutis commented Jul 20, 2024

PolymetisOutis commented Jul 20, 2024 • edited Loading

AmazingAng commented Jul 20, 2024

PolymetisOutis commented Jul 21, 2024

PolymetisOutis commented Jul 27, 2024 • edited Loading

PolymetisOutis commented Jul 27, 2024 • edited Loading

AmazingAng commented Jul 27, 2024

thurendous commented Jul 27, 2024

PolymetisOutis commented Jul 28, 2024

PolymetisOutis commented Jul 28, 2024 • edited Loading

PolymetisOutis commented Jun 2, 2024 •

edited

Loading

PolymetisOutis commented Jun 23, 2024 •

edited

Loading

PolymetisOutis commented Jun 23, 2024 •

edited

Loading

PolymetisOutis commented Jul 5, 2024 •

edited

Loading

thurendous left a comment •

edited

Loading

PolymetisOutis Jul 6, 2024 •

edited

Loading

PolymetisOutis commented Jul 6, 2024 •

edited

Loading

PolymetisOutis commented Jul 7, 2024 •

edited

Loading

PolymetisOutis commented Jul 20, 2024 •

edited

Loading

PolymetisOutis commented Jul 27, 2024 •

edited

Loading

PolymetisOutis commented Jul 27, 2024 •

edited

Loading

PolymetisOutis commented Jul 28, 2024 •

edited

Loading