You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first two features are primarily used for convenience and can be replaced with slightly-less-ergonomic equivalents. The latter two features are used to enable easy construction of Cb callback wrappers - it's likely that the downstream code will need to be changed to not rely on this, or another way is found to make Cb construction simpler.
The text was updated successfully, but these errors were encountered:
1 - has unsafe;
2 - rustc is smart enough to complain that will cause conflicts in the future:
warning: an associated function with this name may be added to the standard library in the future
--> crates/network/src/rpc.rs:65:60
|
65 | let [old_instance, new_instance] = state.instances.get_many_mut([&old_instance_id, &instance_id]).unwrap();
| ^^^^^^^^^^^^
|
= warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior!
= note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
= help: call with fully qualified syntax `get_many_mut(...)` to keep using the current method
= help: add `#![feature(map_many_mut)]` to the crate attributes to enable `HashMap::<K, V, S>::get_many_mut`
= note: `#[warn(unstable_name_collisions)]` on by default
The worst part for me is that we need to use *mut V to bypass the borrow checker that complains about multiple mut borrows to the hashmap.
You could potentially use hashbrown's HashMap directly in the meantime. That's what's used internally anyway so you'd basically bypass the map_many_mut feature.
At present, the runtime does not build on stable Rust. This is due to the use of four features:
The first two features are primarily used for convenience and can be replaced with slightly-less-ergonomic equivalents. The latter two features are used to enable easy construction of
Cb
callback wrappers - it's likely that the downstream code will need to be changed to not rely on this, or another way is found to makeCb
construction simpler.The text was updated successfully, but these errors were encountered: