Handle 404 during validator calls by skipping campaign #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivopaunov @rori4 can you review this? |
ivopaunov
reviewed
Aug 28, 2020
| let dataLeader | ||
| let dataFollower | ||
| let dataLatestNewState | ||
| try { |
There was a problem hiding this comment.
Can't you use await Promise.all([...]) inside try catch or Promise.all([ ... ].map(pr => pr.catch(...))). You can detect the the failed request but they will be send in parallel.
ivopaunov
requested changes
Aug 28, 2020
ivopaunov
requested changes
Aug 28, 2020
status-loop/queryValidators.js
Outdated
| let dataLeader | ||
| let dataFollower | ||
| let dataLatestNewState | ||
| try { | ||
| dataLeader = await getRequest(leaderUrl) | ||
| ;[dataLeader, dataFollower, dataLatestNewState] = await Promise.all([ |
There was a problem hiding this comment.
remove the semicolon and log the catch error
ivopaunov
approved these changes
Aug 28, 2020
Ivshti
force-pushed
the
handle-404-validators
branch
from
8ca0186 to
3155e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #148