Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support more notes element #329

Closed
pkra opened this issue Nov 9, 2021 · 3 comments
Closed

support more notes element #329

pkra opened this issue Nov 9, 2021 · 3 comments
Assignees
@pkra
Labels
bug
Milestone
2021

Comments

@pkra
Copy link
Member

pkra commented Nov 9, 2021

noti2237 (https://github.com/AmerMathSoc/noti/pull/26/) has a notes element (https://jats.nlm.nih.gov/archiving/tag-library/1.2/element/notes.html).
@pkra pkra added this to the 2021 milestone Nov 9, 2021
@pkra pkra self-assigned this Nov 9, 2021
@pkra
Copy link
Member Author

pkra commented Nov 9, 2021

Huh, we already have support

https://github.com/AmerMathSoc/ams-xml-to-html/blob/bffb948005bceaa7fcc1feed023b3626f9bae0bc/lib/notes.js

Something's amiss.

@pkra pkra changed the title support notes element support more notes element Nov 9, 2021
@pkra
Copy link
Member Author

pkra commented Nov 9, 2021

The problem stems from article only processing dedications

https://github.com/AmerMathSoc/ams-xml-to-html/blob/bffb948005bceaa7fcc1feed023b3626f9bae0bc/lib/article.js#L82-L85

@pkra
Copy link
Member Author

pkra commented Nov 9, 2021

We should also start adding data-ams-doc="notes" now that we get more types.

@pkra pkra added bug and removed enhancement labels Nov 9, 2021
@pkra pkra closed this as completed in 8aed454 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkra pkra

Labels
bug
Projects
None yet
Milestone
2021
Development

No branches or pull requests
1 participant
@pkra