Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit usage of ppc-amigaos-strip should be avoided to allow overriding by upstream build tool chains #142

Closed
3246251196 opened this issue Aug 26, 2023 · 2 comments

Comments

@3246251196
Copy link
Member

3246251196 commented Aug 26, 2023

https://github.com/afxgroup/clib2/blob/28aa4eec565160d7fbe90cd534fc57542d921d65/GNUmakefile.os4#L205

While trying to build a native compiler, I came across a situation where one of the rules in CLIB2 was explicitly using ppc-amigaos-strip. Instead, by setting that as a variable - as is already done for CC, AR, LD and RANLIB - it allows the overriding of its value.

The request is to set a variable in the makefile:
STRIP=ppc-amigaos-strip
and use $(STRIP) instead.

===

Reason: Firstly, it is more consistent this way. Other BINs like CC, AR use variables. Secondly, when building ADTOOLS the locations of those binaries may not yet be on the path - in the ADTOOLS makefile there are things like:

CC=/path/to/Xcompiler/bin/ppc-amigaos-gcc
and then CC is fed into CLIB2. This does not happen for STRIP, so it causes a failure.

===

Request to merge into BETA10, which should finally propagate through to MASTER.

@3246251196
Copy link
Member Author

See: #143

@afxgroup
Copy link
Collaborator

In beta10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants