Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Download from Google Drive #28

Open
mantarimay opened this issue Nov 24, 2023 · 12 comments
Open

Failed Download from Google Drive #28

mantarimay opened this issue Nov 24, 2023 · 12 comments
Assignees
Labels
bug Something isn't working download-engine Related to the Brisk download engine

Comments

@mantarimay
Copy link

Distro: openSUSE Tumbleweed
Brisk Version: 1.4.0
Browser: Firefox

Screencast.from.2023-11-24.08-36-05.webm
@mantarimay mantarimay changed the title Cant Download from Google Drive Failed Download from Google Drive Nov 24, 2023
@AminBhst
Copy link
Owner

I was able to reproduce this issue. Apparently the server responds with a 400 and that's why the download is stuck. I'll look into this further and will let you know if there were any updates.
Thanks for bringing this to my attention.

@AminBhst AminBhst added bug Something isn't working download-engine Related to the Brisk download engine labels Nov 24, 2023
@AminBhst AminBhst self-assigned this Nov 24, 2023
@AminBhst
Copy link
Owner

Fixed in V1.4.1

@mantarimay
Copy link
Author

@AminBhst Thanks for the fast update. Now it works if I download from my drive but I still get an error Could not retrieve file information! If I download from outside my drive, like this link

Kooha-2023-11-24-19-43-51.webm

@AminBhst
Copy link
Owner

AminBhst commented Nov 24, 2023

@mantarimay For me the behavior was different. It was able show the download dialog but the file it was going to download was not the expected file (probably some HTML). But surprisingly, it worked totally fine on google chrome albeit the filename had an extra UTF-8 string at the beginning, but it was able to download it. Apparently Firefox does not provide the right download url.
Could you also test it on chrome and let me know if the same happens in your case? You're gonna have to manually install the browser extension

@AminBhst AminBhst reopened this Nov 24, 2023
@mantarimay
Copy link
Author

@AminBhst Yes, it works on Chrome.

Kooha-2023-11-24-21-01-48.webm

@AminBhst
Copy link
Owner

This is just really weird lol. Since fixing this very odd edge-case requires effort I cannot provide an update for it as fast as I did today. I will investigate it in my spare time but it has become the priority for now since this is an issue that might appear on other websites as well. I'll work on it. If you encounter the same problem on other websites as well please let me know.
Thanks

@AminBhst
Copy link
Owner

@mantarimay Hey. I was just about to continue working on this issue but apparently it was fixed by itself lol. Google drive probably did something on their end. If you could, would you please test it again and let me know if this issue was resolved for you as well?

@AminBhst AminBhst closed this as completed Mar 3, 2024
@mantarimay
Copy link
Author

its still happen
Screencast from 2024-03-03 19-51-10.webm

@AminBhst
Copy link
Owner

AminBhst commented Mar 4, 2024

Yikes!

@AminBhst AminBhst reopened this Mar 4, 2024
@AminBhst
Copy link
Owner

AminBhst commented Mar 4, 2024

@mantarimay Could you send me the link for that file?

@mantarimay
Copy link
Author

it still same like first link up there

i tried v1.4.6, it still have this issue

@AminBhst
Copy link
Owner

AminBhst commented May 29, 2024

It's a very weird case in general. The problem is that google drive for some reason expects an auth cookie even for public links. Thanks for reminding me though. I will continue working on this. Still not sure how to resolve this since I noticed other download managers have this issue as well (other than IDM). It might need some magic to make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working download-engine Related to the Brisk download engine
Projects
Status: Backlog
Development

No branches or pull requests

2 participants