Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The segment colors in the Segmented Arc is not rendered correctly #189

Closed
1 task done
AmoebeLabs opened this issue May 1, 2023 · 0 comments · Fixed by #190
Closed
1 task done

The segment colors in the Segmented Arc is not rendered correctly #189

AmoebeLabs opened this issue May 1, 2023 · 0 comments · Fixed by #190
Assignees
Labels
bug Something isn't working tool/segmented-arc About the segmented arc tool

Comments

@AmoebeLabs
Copy link
Owner

Bug report notice

Before you file a bug, make sure that you did not make a configuration mistake. The Swiss Army Knife in its current state does not yet have full configuration sanity checks!

So make sure your problem is not related to that!

  • Yes, I'm sure that it is not a configuration mistake

Bug description

A clear and concise description of what the bug is.
After #186, the segmented arc is sometimes not rendered correctly:

  • uses the wrong colors
  • bugs out on index out of range while rendering

It seems that correcting the for loop exhibits a bug! It is weird though, that WITH that bug, the segarc was rendered correctly...

This is how it should render, this is before fixing the for loop:
image

image

And this is what it became after fixing the for loop bug:
image

image

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop browser (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 110]

Companion App on Smartphone/Tablet (please complete the following information):

  • Device: [e.g. iPhone16]
  • OS: [e.g. iOS16]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 16]

Additional context
Add any other context about the problem here.

(Optional): Suggested Solution

Any suggested solution to this bug.

@AmoebeLabs AmoebeLabs added bug Something isn't working tool/segmented-arc About the segmented arc tool labels May 1, 2023
@AmoebeLabs AmoebeLabs added this to the Release v2.4.1 milestone May 1, 2023
@AmoebeLabs AmoebeLabs self-assigned this May 1, 2023
@AmoebeLabs AmoebeLabs linked a pull request May 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool/segmented-arc About the segmented arc tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant