Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Create RAP specific content to be used with new front-end #259

Open
FreekOrdina opened this issue Feb 27, 2023 · 3 comments
Open

Epic: Create RAP specific content to be used with new front-end #259

FreekOrdina opened this issue Feb 27, 2023 · 3 comments

Comments

@FreekOrdina
Copy link
Contributor

FreekOrdina commented Feb 27, 2023

Purpose
The purpose of this issue is to make RAP run on the new angular-based front-end.
When all generic front-end components and Ampersand compiler are ready, we expect that ~75% of the RAP application is working. The other 25% is custom code for RAP specific.

Tasks
Below, we have an analysis of the files (in the RAP repo) that we expect to need a change.

@Michiel-s Michiel-s transferred this issue from AmpersandTarski/prototype-frontend Mar 18, 2023
@stefjoosten
Copy link
Contributor

stefjoosten commented Apr 24, 2023

Analysis

I expect that the RAP-specific content is exclusively in the directory RAP/RAP4/customizations and the RAP/RAP4/templates. RAP has no custom BOX-templates, so none need to be adapted. Maybe some view templates need work. We need to check all 4 of them.

directory file purpose change required
bootstrap/files back-end functions no
bootstrap/files execEngineDateTime.php time stamping no
bootstrap/files ExecEngineFunctions.php automated evaluation no
config oauth.yaml SIAM yes
config project.yaml prototype framework config yes
extensions/RAP4/src Command.php calling the compiler yes
public RAP specific goodies no
public ACE editor yes
Traefik proxy config no

As for view templates, the following need to be verified

RAP source code file uses HTML TEMPLATE
RAP4\src\Analyse.ifc View-ShowConceptualDiagram.html
RAP4\src\Scripts.ifc View-ParseAsHtml.html
RAP4\src\Scripts.adl View-FILEOBJECT.html
RAP4\src\Scripts.adl View-ACE.html

The docker file needs the following changes:

  1. Restructure the docker file reusing parts of https://gitlab.com/semantic-treehouse/semantic-treehouse-mirror/-/blob/main/Dockerfile-v3 as example.
  2. In the meantime, @Michiel-s publishes the prototype framework v2.0, which contains the new Angular innovation.
  3. transition from v 1.12 to v2. There may be new bugs in the back-end.
  4. The same for the student prototype image, to give students access to the new Angular functionality. Most likely this involves adapting the base image, removing the templates (RAP/RAP4USERS/templates), and adapting the bash script.

@stefjoosten
Copy link
Contributor

Progress on Ampersand 5

On Feb 4th, 2024, The Ampersand compiler had a syntax-breaking upgrade to vs. 5.
I have edited the source code of RAP, in commit 948013a (in branch names-and-labels), such that the command ampersand proto RAP4.adl --build-recipe RAP yields no errors, when using Ampersand vs. 5.0.1. This includes the edits in RAP4 made by @SimonvRoozendaalOrdina

@hanjoosten
Copy link
Member

I see quite some updates of templates in the RAP4 directory. I cannot imagine that that is correct, but I could be wrong. @Michiel-s will know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

6 participants