Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime matrix inversion error causes rendering to stop #6954

Closed
mksquires opened this issue Aug 24, 2018 · 5 comments
Closed

Runtime matrix inversion error causes rendering to stop #6954

mksquires opened this issue Aug 24, 2018 · 5 comments

Comments

@mksquires
Copy link

In the master branch (currently 9287c3c) there appears to be an issue where transformation matrix inversion causes the rendering system to stop. This issue may be demonstrated via the following CZML file in the gist, https://gist.github.com/mksquires/cff0be46da9525f5fc0179becc430a62.

@mramato
Copy link
Contributor

mramato commented Aug 24, 2018

Thanks @mksquires @bagnell said he already had a fix for this so hopefully he'll open a PR soon.

@mksquires
Copy link
Author

Sounds good! If he can't get to it let me know and I can fix it.

@mksquires
Copy link
Author

To add some information regarding this issue:

  • the render failure occurs only when animations are active
  • the render failure is due to the animation system creating transformation matrices for certain nodes with scale factors near zero. The matrix inversion code determines that this matrix is singular and throws.
    I do have code to fix this issue and will open a PR soon.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 12, 2018

Thanks @mksquires! Sorry for the delay on this. Opening a PR is usually the best way to get a fix through quickly if you have a solution ready to go.

@mksquires
Copy link
Author

Thanks @hpinkos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants