Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added _3DTILESDIFFUSE semantic #174

Merged
merged 5 commits into from
Nov 1, 2016
Merged

Added _3DTILESDIFFUSE semantic #174

merged 5 commits into from
Nov 1, 2016

Conversation

lilleyse
Copy link
Contributor

@pjcozzi
Is it fine that these be added by default?

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 15, 2016

@lilleyse IIRC we discussed offline that this shouldn't be part of gltf-pipeline since it is 3D Tiles specific. I thought we planned to put it a 3D Tiles specific COLLADA2GLTF / obj2gltf workflow...maybe 3d-tiles-tools is the right place so we don't have to update every glTF converter?

@lilleyse
Copy link
Contributor Author

Updated.
As discussed offline, it only adds the _3DTILESDIFFUSE semantic if optimizeForCesium is true.

@lilleyse
Copy link
Contributor Author

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 1, 2016

Is there a unit test for optimizeForCesium? Can we add an expectation for this new case?

Also update CHANGES.md.

@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 1, 2016

Added unit tests and updated CHANGES.md.

@pjcozzi pjcozzi merged commit 581a60a into master Nov 1, 2016
@pjcozzi pjcozzi deleted the 3d-tiles-diffuse branch November 1, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants