-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect this fantastic tool #97
Comments
Branches 'auto' and 'idf4' of the fork are outdated. The current branch is dev-esp32. I have no plan to publish my fork in NPM repository, as I am not the author of this application. |
I would certainly appreciate that. However, without commitment or interest from @AndiDittrich this would be in vain. |
dear @marcelstoer , currently i've absolutely no time to maintain/enhance this project |
Np, I know how that feels. @serg3295 did a great job making your tool compatible with current versions of the ESP32 releases (keeping the ESP8266 support as-is). The question is, would you be willing to accept his PR and push a new release to the NPM repository i.e. minimal effort? |
"simple" is relative...merging requires some time...just took a quick look onto the branch |
Hello, @AndiDittrich I opened a PR that contains only 3 commits to facilitate reviewing. These are the minimum changes to support esp32xx chips In this PR:
I can add commits with major upgrade for glob, commander and update dependencies if it will be necessary. |
Thanks a lot @serg3295 for your efforts!
I guess that's fine. The dependabot in this project had previously opened a pile of PRs to get this fixed (still open). |
thanks, just two question (comments) regarding backward compat |
I updated all dependencies and opened two PRs. You can simply drop these PRs if they don't make sense or break backward compatibility. |
Thanks @serg3295, looks sensible. So, a pragmatic way forward could be to merge the first PR and release this as 3.x, and then merge the 2nd. |
Perhaps. However, there is not much difference between node18 (for serialport) and node20 (for glob). It is a breaking change anyway. |
nodejs 18 ist required for current debian stable |
Well, then the |
I changed |
(somewhat related to #101) @AndiDittrich allow me to take you up on your initial comment here
It's sad to hear, but I can very much relate to that. I know from personal experience how demanding it can be to maintain even small projects consistently over a long period of time. Sometimes it's the lack of extra free-time, sometimes the lack of motivation, sometimes the lack of community support, sometimes other personal stuff...and sometimes a bit of all of that. Long story short, I would hate to see this great project become yet another slowly dying OSS project. Would you be willing to share the maintenance burden? I could review PRs and help with cutting releases and pushing them to the NPM registry. |
This a plea for @AndiDittrich & @serg3295 to join forces and to bring NodeMCU-Tool back to the spotlight one way or the other.
I am sure the community would very much appreciate if the two of you could find a way to merge your efforts. Having a single NodeMCU-Tool project has lots of benefits for the community. Regardless of what comes out of this: thanks for what you've contributed so far!
The text was updated successfully, but these errors were encountered: