This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
fix(settings): single choice prefs not being dismissed when clicking … #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outside the dialog fix(settings): Single choice prefs not being dismissed when clicking … …outside the dialog Some preferences that do not have an "ok" or "cancel" button forced us to click on the choice again so that the card disappeared Now the following preferences are dismissible: - UI Mode (Theme) - Tab Size - Empty elements behavior
itsaky
suggested changes
Sep 14, 2023
There was a problem hiding this comment.
Instead of overriding onConfigureDialog and directly modifying the dialog properties, override the dialogCancellable property and set it to true.
|
Ok, I thought about that, but I thought the "false" behavior by default was used for other things. I will correct it soon |
You have to "override" the property in the respective classes. Modification in |
|
I made the changes, see if it was supposed to stay like this |
itsaky
approved these changes
Sep 14, 2023
itsaky
pushed a commit
that referenced
this pull request
Nov 9, 2023
…outside dialog (#1311) Some preferences that do not have an "Ok" or "cancel" button forced us to click on the choice again so that the card disappeared Now the following preferences are dismissable: - UI Mode (Theme) - Tab Size - Empty elements behavior
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…outside the dialog
Some preferences that do not have an "ok" or "cancel" button forced us to click on the choice again so that the card disappeared
Now the following preferences are dismissible: