Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Accept scopes and multiple imports from jspm #13

Closed
AngelMunoz opened this issue Sep 22, 2021 · 1 comment
Closed

Accept scopes and multiple imports from jspm #13

AngelMunoz opened this issue Sep 22, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@AngelMunoz
Copy link
Owner

Packages with multiple dependencies like lit are not automatically processed by jspm, jspm prefers to send a whole tree of imports which if we want to support it (we do) We need to change the way we handle the JSPM response. For example this what is delivered from Lit.

{
    "staticDeps": [
        "https://ga.jspm.io/npm:@lit/reactive-element@1.0.0-rc.3/css-tag.js",
        "https://ga.jspm.io/npm:@lit/reactive-element@1.0.0-rc.3/reactive-element.js",
        "https://ga.jspm.io/npm:lit-element@3.0.0-rc.4/lit-element.js",
        "https://ga.jspm.io/npm:lit-html@2.0.0-rc.5/lit-html.js",
        "https://ga.jspm.io/npm:lit@2.0.0/index.js"
    ],
    "dynamicDeps": [],
    "map": {
        "imports": {
            "lit": "https://ga.jspm.io/npm:lit@2.0.0/index.js"
        },
        "scopes": {
            "https://ga.jspm.io/": {
                "@lit/reactive-element": "https://ga.jspm.io/npm:@lit/reactive-element@1.0.0-rc.3/reactive-element.js",
                "lit-element/lit-element.js": "https://ga.jspm.io/npm:lit-element@3.0.0-rc.4/lit-element.js",
                "lit-html": "https://ga.jspm.io/npm:lit-html@2.0.0-rc.5/lit-html.js"
            }
        }
    }
}

currently we expect the import, but we're not handling the scopes, that or course makes the jspm imports to fail in the browser, skypack and presumaby the other cdns handle the imports by themselves (i.e they transform to full specifiers) so that's why we got caught by this with jspm

@AngelMunoz AngelMunoz added the bug Something isn't working label Sep 22, 2021
@AngelMunoz AngelMunoz pinned this issue Sep 22, 2021
@AngelMunoz
Copy link
Owner Author

fixed in v0.5.0

@AngelMunoz AngelMunoz unpinned this issue Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant