Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests don't work with test_server 0.0.31 #117

Open
rapgro opened this issue Nov 1, 2018 · 1 comment · May be fixed by #137
Open

Tests don't work with test_server 0.0.31 #117

rapgro opened this issue Nov 1, 2018 · 1 comment · May be fixed by #137

Comments

@rapgro
Copy link

rapgro commented Nov 1, 2018 •
edited
Loading

API of test_server changed with 0.0.31 compared to 0.0.30, there's a decision to replace tornado with bottle as the backend. Please remove the parameter engine from the constructor call.

PySocks/test/test_pysocks.py

Line 83 in b687a34

engine='subprocess')

lorien/test_server@5465db0#diff-c5ce133e5ada690e691b433ea45f0519
@mgorny
Copy link

mgorny commented Nov 18, 2019

This is not the only change necessary. Apparently a number of tests fail with 0.0.30+:

test/test_pysocks.py:115: in assert_proxy_response
    self.assertEqual(content, resp_body)
E   AssertionError: b'zzz' != b'3\r\nzzz\r\n0'

and alike.

jayvdb added a commit to jayvdb/PySocks that referenced this issue Dec 4, 2019
@jayvdb
Update tests for test-server 0.0.31
983f045 
Closes Anorov#117
@jayvdb jayvdb linked a pull request Dec 4, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tests for test-server 0.0.31 jayvdb/PySocks
2 participants
@mgorny @rapgro