Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for test-server 0.0.31 #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update tests for test-server 0.0.31 #137

wants to merge 1 commit into from

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Dec 4, 2019

Closes #117

jayvdb
jayvdb commented Dec 4, 2019
View reviewed changes
test/test_pysocks.py
@@ -112,6 +111,7 @@ def assert_proxy_response(self, resp_data, content, address,
self.test_server.request['headers']['user-agent'])
self.assertEqual('%s:%d' % address,
self.test_server.request['headers']['host'])
content = b'3\r\n' + content + b'\r\n0'
Copy link
Author

@jayvdb jayvdb Dec 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent investigated why the 3 & 0 are appearing.

Also I noticed on openSUSE_Factory_zSystems' arch 's390x' this intermittently fails with

AssertionError: '3\r\nzzz\r\n0' != '3\r\nzzz\r\n'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests don't work with test_server 0.0.31
1 participant
@jayvdb