Make SocksiPy legacy functions kwarg-compatible #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. Looks like you forgot |
|
Eek! That's what I get for forgetting to check the tab I ran the tests in I guess. |
mleinart
force-pushed
the
socksipy_compatibility/setdefaultproxy
branch
from
f8e1566
to
08b00ba
Compare
mleinart
force-pushed
the
socksipy_compatibility/setdefaultproxy
branch
from
08b00ba
to
682ac28
Compare
This was referenced Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across this when trying to use PySocks as a drop-in for SocksiPy. 298d7c9 renamed a bunch of methods and aliased them to their old names, however it changed one of the kwargs for setproxy() and setdefaultproxy() which breaks any invocations explicitly using the old kwargs.
This is pretty minor and I'm unsure if it's worth the trouble to fix so feel free to close if necessary