This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
DUNE plugin proposal #105
Merged
DUNE plugin proposal #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelik
commented
Jan 23, 2023
mikelik
force-pushed
the
mikelik/plugin
branch
from
9469a4a to
6cb0849
Compare
This was
linked to
issues
Jan 23, 2023
ScottBailey
reviewed
Jan 23, 2023
jolly-fellow
approved these changes
Jan 23, 2023
ScottBailey
reviewed
Jan 23, 2023
ScottBailey
reviewed
Jan 23, 2023
There was a problem hiding this comment.
src/plugin/README.md should probably be added.
Additionally, it might make sense to move plugin_example to example/plugins?
Finally, we probably want to add the examples to packaging.
See inline comments for other thoughts.
Generally, this LGTM. Just needs a touch more polish.
mikelik
force-pushed
the
mikelik/plugin
branch
from
0368502 to
22e184e
Compare
Added implementation details. Add docs, tests and plugin_example to the packaging. Added other code review fixes.
mikelik
force-pushed
the
mikelik/plugin
branch
from
22e184e to
922f9a3
Compare
ScottBailey
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
I have reviewed the code and performed the following review actions:
- Built and installed the debian package.
- Tested the hello plugin in the local source repo as well as the installed (
/usr/opt/...) version. - Ran the regression tests including the new plugin test.
- Ran pylint against new and changed files.
This change looks good to me.
ScottBailey
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue described in #102.
Description added in src/PLUGIN.md.