Several errata fixes in the description of DUNE. #84
Conversation
|
Hey @jgiszczak could you approve this PR if the text is OK. |
| >+ Rebuild the image by calling ./bootstrap.sh. | ||
| >+ Add a root directory of host system to list of shared directories in Docker Desktop settings. | ||
| >+ Add a root directory of the host system to the list of shared directories in Docker Desktop settings. |
There was a problem hiding this comment.
Shouldn't this be "Add a directory..."? In a Unix-style system there's only one root directory and it's not customarily shared with containers.
There was a problem hiding this comment.
In DUNE it is definitely shared with containers. It is not my decision and I'd prefer to share directories in /home but it is a part of DUNEs design and it is very difficult to change on this stage. So I propose to leave it as is or make a new issue for this task and merge this PR which fix erratas.
There was a problem hiding this comment.
It really does require the entire filesystem to be shared with the container?
In that case, the wording should be "Add the root directory..."
And yes that's awful.
There was a problem hiding this comment.
It really does require the entire filesystem to be shared with the container?
I guess this is not known exactly until the end of development. So at the beginning they decided to share all to don't limit themselves in case they will need to have access somewhere in the file system.
In that case, the wording should be "Add the root directory..."
And yes that's awful.
IMHO it will be possible to change when we will release it and get feedback from real users. We will know better what is really need and what is not. Then it will be easier to make decision about limiting accesses, rights and so on.
So now, if you have no other remarks, I will be glad if you approve this PR and I will merge it.
There was a problem hiding this comment.
I guess this is not known exactly until the end of development. So at the beginning they decided to share all to don't limit themselves in case they will need to have access somewhere in the file system.
In that case, the text needs to change as I suggested. Sharing the entirety of the filesystem is so unusual that the ambiguity needs to be removed. I assumed something else was meant because it's so unusual. I even suggest adding a disclaimer sentence, incorporating your explanation in this thread into the document. I assure you I won't be the only person questioning the document if there's no explanation.
There was a problem hiding this comment.
In that case, the text needs to change as I suggested. Sharing the entirety of the filesystem is so unusual that the ambiguity needs to be removed. I assumed something else was meant because it's so unusual. I even suggest adding a disclaimer sentence, incorporating your explanation in this thread into the document. I assure you I won't be the only person questioning the document if there's no explanation.
Let's solve problems as they come. I decided to add this PR because I was confused by architecture of Docker. I was solving of problem with files shared between the host and the container and I was sure that Docker Desktop is just a frontend over dockerd daemon. I was very surprised to found that Docker Desktop works even if the dockerd is shot down. So I decided to highlight this information for the users of DUNE to save their time.
If someone asks about why do they need to share whole root with the container I will write additional topic which explain this subject in separated PR. IMHO it is better so solve one issue in one PR and merge them separately.
|
@jgiszczak If you have no other remarks, Please approve this PR and I will merge it. |
No description provided.