This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Added creating rpm and Chocolatey packages #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added chocolatey packaging and documentation about it. Updated documentation how to install DUNE on Windows and on Linux. Updated dune.bat because it was causing an error on my side.
mikelik
commented
Dec 30, 2022
C:\<PathToDUNE>\DUNE$ .\bootstrap.bat | ||
``` | ||
1. Install [Chocolatey](https://docs.chocolatey.org/en-us/choco/setup) | ||
2. From the [latest release](https://github.com/AntelopeIO/DUNE/releases/latest) page, download latest DUNE nupkg or visit the [release tags](https://github.com/AntelopeIO/DUNE/releases) page to download specific version of DUNE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good practice is to publish packages in Chocolatey repository, so I have created a separate issue for it:
#95
ScottBailey
reviewed
Dec 30, 2022
ScottBailey
reviewed
Dec 30, 2022
ScottBailey
suggested changes
Dec 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments:
- Update
packaging/generate_package.sh
to include reportingrpm
as an option. - Update rpm package name to lowercase only.
ScottBailey
suggested changes
Dec 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional dependencies for rpm are wget
and curl
.
jolly-fellow
reviewed
Jan 2, 2023
ScottBailey
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jolly-fellow
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating rpm and installing is just usual stuff.
However for Chocolatey I have added instruction: