Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/install_deps.sh no longer exists in 4.0 branch #1172

Closed
matthewdarwin opened this issue May 13, 2023 · 4 comments · Fixed by #1193 or #1194
Closed

scripts/install_deps.sh no longer exists in 4.0 branch #1172

matthewdarwin opened this issue May 13, 2023 · 4 comments · Fixed by #1193 or #1194
Assignees
Labels
actionable bug Something isn't working 👍 lgtm
Milestone

Comments

@matthewdarwin
Copy link

matthewdarwin commented May 13, 2023

When leap 4.0 was released, It had a scripts/install_deps.sh. When I was building a recent patch, I noticed the script is no longer there.

Ideally the build instructions don't change within a release cycle. They can change at major releases of course.

I have (since the pre nodeos 1.0 days) my own custom build script which generates an apt package for our infrasructure. It looks like below: $TAG is filled in from our build system, which is whatever tag/branch I want to build. $TEMPDIR is a temporary directory where the build runs.

#!/bin/sh

set -e

lib=$(cat lib)
export HOME=$TEMPDIR/builder
echo "LIB = ${lib}"
echo "HOME = ${HOME}"

mkdir -p $TEMPDIR/repo/usr/bin
mkdir -p $TEMPDIR/repo/etc/nodeos
mkdir -p $TEMPDIR/repo/usr/share/bash-completion/completions
#cp -pra *.diff $TEMPDIR

cd $TEMPDIR
git clone --depth 1 -b $TAG https://github.com/AntelopeIO/leap.git --recursive
cd leap
git submodule update --init --recursive
mkdir build
scripts/install_deps.sh
time scripts/pinned_build.sh /local/lib/${lib} $TEMPDIR/leap/build 30
cd ..
leap/build/bin/nodeos --print-default-config > $TEMPDIR/repo/etc/nodeos/config.ini.example
cp leap/build/bin/* $TEMPDIR/repo/usr/bin/
cp leap/build/programs/cleos/bash-completion/completions/cleos $TEMPDIR/repo/usr/share/bash-completion/completions/cleos
cp leap/build/programs/leap-util/bash-completion/completions/leap-util $TEMPDIR/repo/usr/share/bash-completion/completions/leap-util
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 13, 2023
@heifner heifner added bug Something isn't working discussion and removed triage labels May 13, 2023
@matthewdarwin
Copy link
Author

FWIW, the final layout of the build looks like this:

  /etc/systemd_monitor/nodeos
  /etc/nodeos/snapshot_version
  /etc/nodeos/config.ini.example
  /DEBIAN/control
  /DEBIAN/postinst
  /DEBIAN/conffiles
  /DEBIAN/prerm
  /lib/systemd/system/nodeos.service
  /usr/bin/cleos
  /usr/bin/nodeos
  /usr/bin/leap-util
  /usr/bin/trace_api_util
  /usr/bin/keosd
  /usr/share/bash-completion/completions/cleos
  /usr/share/bash-completion/completions/leap-util

@bhazzard
Copy link

We need to back this out for 4.0.1 so as not to have a breaking change (a missing script) in a patch release.

@heifner
Copy link
Member

heifner commented May 17, 2023

Removed via #857

@arhag
Copy link
Member

arhag commented May 17, 2023

We agreed to just revert #857.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable bug Something isn't working 👍 lgtm
Projects
Archived in project
5 participants