Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging #177

Closed
4 of 5 tasks
pktiuk opened this issue Jul 26, 2021 · 0 comments · Fixed by #180
Closed
4 of 5 tasks

Refactor logging #177

pktiuk opened this issue Jul 26, 2021 · 0 comments · Fixed by #180
Assignees
@pktiuk
Labels
refactor Issues connected with cleaning-up repository

Comments

@pktiuk
Copy link
Member

pktiuk commented Jul 26, 2021 •
edited
Loading

In current form logs are almost useless, there are a lot of problems with them:

  • there are multiple ways of logging (qDebug and Logger::LogDebug)
  • Logs are not readable (don't show location or time)
  • saving to file doesn't work Saving logs into file doesn't work properly. #78
  • calling qInstallMessageHandler in every method is a bad idea it should be called only ONCE
  • and so on...
@pktiuk pktiuk added the refactor Issues connected with cleaning-up repository label Jul 26, 2021
@pktiuk pktiuk self-assigned this Jul 26, 2021
This was referenced Jul 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pktiuk pktiuk

Labels
refactor Issues connected with cleaning-up repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite logging system AntiMicroX/antimicrox
1 participant
@pktiuk