Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lenses to the mix #18

Open
lbreede opened this issue Nov 14, 2022 · 3 comments
Open

Adding lenses to the mix #18

lbreede opened this issue Nov 14, 2022 · 3 comments

Comments

@lbreede
Copy link
Contributor

lbreede commented Nov 14, 2022

I've dabbled in physical lens emulation in Houdini and I wonder if there's a standard for lens characteristics like distortion, vignetting etc.
USD wise, it can probably be a focal length override on the camera, but I imagine the simulation is different from renderer to renderer. I've only ever tried the Karma physical lens shader. Just food for thought :)

@AntonPalmqvist
Copy link
Owner

Unfortunately there doesn't seem to be any standard just yet. As you say, it varies from renderer to renderer what kind of lens characteristics you can use.

Blender, for example, uses 4th degree polynomials for lens distortion, while the data you get from databases such as Lensfun is not compatible with that format.

Other interesting links on the subject. However, none of them seem to have converged around a standard:

I'm hoping to expand the database with this kind of data, so please let me know if you have additional resources on this topic!

@lbreede
Copy link
Contributor Author

lbreede commented Nov 14, 2022

yeah I'd usually point to Zeno's Lentil work. It's the best. The Karma Physical Lens Shader is getting better and better and runs on the GPU finally :)

@lbreede
Copy link
Contributor Author

lbreede commented Nov 14, 2022

If you look at my fork you can see that there were tests that ran for every push and PR. Number 5 failed for example because changed a sensor size to be a list of three numbers. Therefore:
test_sensorSizes self.assertEqual(len(size), 2) AssertionError: 3 != 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants