Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: rename Bookmarks to Starred/Favorites #70

Closed
huyz opened this issue Apr 26, 2024 · 3 comments
Closed

[feature]: rename Bookmarks to Starred/Favorites #70

huyz opened this issue Apr 26, 2024 · 3 comments
Assignees
Labels
improvement New feature or request

Comments

@huyz
Copy link

huyz commented Apr 26, 2024

Proposal

When I see Bookmarks I always think of Web Browser bookmarks. It's quite confusing to users to have 2 meanings.

Indeed the settings use both meanings:
screenshot 2024-04-26T083553Z@2x
screenshot 2024-04-26T083626Z@2x

I suggest that KeyClub stop using the term "bookmarks" and instead use the common alternatives: "starred", "favorites", "pinned", etc.

Alternatives

No response

@huyz huyz added the improvement New feature or request label Apr 26, 2024
@Anze
Copy link
Owner

Anze commented Apr 27, 2024

Hey huyz,
I can change the icon to a star. When it comes to the action labels, I'm struggling to finding the right words for "Add to favorites" and "Remove from favorites". Personally, I prefer the simplicity of "Bookmark" and "Unbookmark" due to their simplicity and single-word format. Please note that (almost) every option in the menu consists of a single word for the call-to-action. Would you be up for giving some great alternatives?

@huyz
Copy link
Author

huyz commented May 1, 2024

@Anze Common words for that are the verbs "star" and "unstar" if you just want single words that parallel "bookmark" and "unbookmark". Or "favorite" and "unfavorite". These nouns are commonly converted to verbs.

For example, Slack has:
screenshot 2024-05-01T084439Z@2x

screenshot 2024-05-01T084122Z@2x

and Linear has:
screenshot 2024-05-01T083832Z
but inconsistently, has:
screenshot 2024-05-01T085200Z

For comparison, some samples of other apps I use today are wordier:

  • Gmail
    screenshot 2024-05-01T084741Z@2x

  • Notion
    screenshot 2024-05-01T083757Z@2x

  • IntelliJ's Git tool window
    screenshot 2024-05-01T085243Z@2x

@huyz
Copy link
Author

huyz commented May 1, 2024

An exact use by Atlassian Confluence of "star"/"unstar":
screenshot 2024-05-01T085754Z@2x
screenshot 2024-05-01T085801Z@2x

@Anze Anze self-assigned this May 12, 2024
@Anze Anze moved this to In Progress in KeyClu Roadmap May 12, 2024
@Anze Anze moved this from In Progress to Done in KeyClu Roadmap May 17, 2024
@Anze Anze closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants