-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: only check trace in tests if has a reason to #1128
Conversation
ape-config.yaml
ape-config.yaml
e84a19f
to
1f79d75
Compare
a3e1490
to
0e7c874
Compare
Hmm, thinking I may have a better solution, BRB. |
ape-config.yaml
Update: will have to ignore for now , see ethereum/go-ethereum#26154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a configuration that should also apply to the dev-message assertion or do we only mean tracing here as in gas tracing / profiling?
I removed the config because I found out it wasn't needed! So no worries there :) |
What I did
Change it to not check
call_tree
unnecessarily (if no--gas
flag given).This makes tests run faster when not using
--gas
NOTE: This PR also fixes many race conditions and flakinesses in the tests that came up when adding a test as well as turning off geth snapshotting for now because of this issue: ethereum/go-ethereum#26154
How I did it
check if needing gas report before checking the grabbing the call tree.
How to verify it
Can work with Hardhat project with tracing issues and things still work as far as testing goes (obviously sans all tracing features)
Checklist