We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I suggest to implement IDisposable. It is simpler to disconnect, if IDisposable is implemented.
IDisposable
When code gets complicated, you have two options:
Disconnect()
finally
I offer implement this. Do you agree and should I make a PR? 😉
Currently:
var client = new ModbusTcpClient(); // code here ... // disconnect client.Disconnect();
Suggestion:
using (var client = new ModbusTcpClient()) { // code here ... // will disconnect automatically }
The text was updated successfully, but these errors were encountered:
Good suggestion, please go ahead :-)
Sorry, something went wrong.
I has implemented it in v5, so I am closing this issue for now.
No branches or pull requests
I suggest to implement IDisposable. It is simpler to disconnect, if
IDisposable
is implemented.When code gets complicated, you have two options:
Disconnect()
in multiple placesDisconnect()
only once infinally
blockI offer implement this. Do you agree and should I make a PR? 😉
Currently:
Suggestion:
The text was updated successfully, but these errors were encountered: