diff --git a/src/Polly.Core/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderExtensions.cs b/src/Polly.Core/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderExtensions.cs index 9f91f1bc45..b9ead87a5a 100644 --- a/src/Polly.Core/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderExtensions.cs +++ b/src/Polly.Core/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderExtensions.cs @@ -102,8 +102,6 @@ public static ResilienceStrategyBuilder AddSimpleCircuitBreaker(this ResilienceS private static TBuilder AddAdvancedCircuitBreakerCore(this TBuilder builder, AdvancedCircuitBreakerStrategyOptions options) where TBuilder : ResilienceStrategyBuilderBase { - ValidationHelper.ValidateObject(options, "The advanced circuit breaker strategy options are invalid."); - builder.AddStrategy( context => { @@ -122,8 +120,6 @@ private static TBuilder AddAdvancedCircuitBreakerCore(this TB private static TBuilder AddSimpleCircuitBreakerCore(this TBuilder builder, SimpleCircuitBreakerStrategyOptions options) where TBuilder : ResilienceStrategyBuilderBase { - ValidationHelper.ValidateObject(options, "The circuit breaker strategy options are invalid."); - builder.AddStrategy(context => CreateStrategy(context, options, new ConsecutiveFailuresCircuitBehavior(options.FailureThreshold)), options); return builder; } diff --git a/src/Polly.Core/Fallback/FallbackResilienceStrategyBuilderExtensions.cs b/src/Polly.Core/Fallback/FallbackResilienceStrategyBuilderExtensions.cs index 3ae51e0e94..7a6165cea4 100644 --- a/src/Polly.Core/Fallback/FallbackResilienceStrategyBuilderExtensions.cs +++ b/src/Polly.Core/Fallback/FallbackResilienceStrategyBuilderExtensions.cs @@ -76,8 +76,6 @@ internal static ResilienceStrategyBuilder AddFallback(this ResilienceStrategyBui internal static void AddFallbackCore(this ResilienceStrategyBuilderBase builder, FallbackStrategyOptions options) { - ValidationHelper.ValidateObject(options, "The fallback strategy options are invalid."); - builder.AddStrategy(context => { var handler = new FallbackHandler( diff --git a/src/Polly.Core/Hedging/HedgingResilienceStrategyBuilderExtensions.cs b/src/Polly.Core/Hedging/HedgingResilienceStrategyBuilderExtensions.cs index bc8b845f29..4c43896da9 100644 --- a/src/Polly.Core/Hedging/HedgingResilienceStrategyBuilderExtensions.cs +++ b/src/Polly.Core/Hedging/HedgingResilienceStrategyBuilderExtensions.cs @@ -46,8 +46,6 @@ internal static ResilienceStrategyBuilder AddHedging(this ResilienceStrategyBuil internal static void AddHedgingCore(this ResilienceStrategyBuilderBase builder, HedgingStrategyOptions options) { - ValidationHelper.ValidateObject(options, "The hedging strategy options are invalid."); - builder.AddStrategy(context => { var handler = new HedgingHandler( diff --git a/src/Polly.Core/ResilienceStrategyBuilderBase.cs b/src/Polly.Core/ResilienceStrategyBuilderBase.cs index 49a9f5a44c..ed6e17f5c5 100644 --- a/src/Polly.Core/ResilienceStrategyBuilderBase.cs +++ b/src/Polly.Core/ResilienceStrategyBuilderBase.cs @@ -85,7 +85,7 @@ public void AddStrategy(Func AddRetry(this Resilien private static TBuilder AddRetryCore(this TBuilder builder, RetryStrategyOptions options) where TBuilder : ResilienceStrategyBuilderBase { - ValidationHelper.ValidateObject(options, "The retry strategy options are invalid."); - builder.AddStrategy(context => new RetryResilienceStrategy( options.BaseDelay, diff --git a/src/Polly.Core/Timeout/TimeoutResilienceStrategyBuilderExtensions.cs b/src/Polly.Core/Timeout/TimeoutResilienceStrategyBuilderExtensions.cs index d57edb6568..5dc00b14bc 100644 --- a/src/Polly.Core/Timeout/TimeoutResilienceStrategyBuilderExtensions.cs +++ b/src/Polly.Core/Timeout/TimeoutResilienceStrategyBuilderExtensions.cs @@ -43,8 +43,6 @@ public static TBuilder AddTimeout(this TBuilder builder, TimeoutStrate Guard.NotNull(builder); Guard.NotNull(options); - ValidationHelper.ValidateObject(options, "The timeout strategy options are invalid.*"); - builder.AddStrategy(context => new TimeoutResilienceStrategy(options, context.TimeProvider, context.Telemetry), options); return builder; } diff --git a/src/Polly.Core/Utils/TypeNameFormatter.cs b/src/Polly.Core/Utils/TypeNameFormatter.cs new file mode 100644 index 0000000000..6ec5f07fdd --- /dev/null +++ b/src/Polly.Core/Utils/TypeNameFormatter.cs @@ -0,0 +1,24 @@ +using System; + +namespace Polly.Utils; + +internal static class TypeNameFormatter +{ + private const int GenericSuffixLength = 2; + + public static string Format(Type type) + { + if (!type.IsGenericType) + { + return type.Name; + } + + var args = type.GetGenericArguments(); + if (args.Length != 1) + { + return type.Name; + } + + return $"{type.Name.Substring(0, type.Name.Length - GenericSuffixLength)}<{Format(args[0])}>"; + } +} diff --git a/src/Polly.RateLimiting/Polly.RateLimiting.csproj b/src/Polly.RateLimiting/Polly.RateLimiting.csproj index 309aa5624c..adb54088e7 100644 --- a/src/Polly.RateLimiting/Polly.RateLimiting.csproj +++ b/src/Polly.RateLimiting/Polly.RateLimiting.csproj @@ -13,7 +13,6 @@ - diff --git a/src/Polly.RateLimiting/RateLimiterResilienceStrategyBuilderExtensions.cs b/src/Polly.RateLimiting/RateLimiterResilienceStrategyBuilderExtensions.cs index 9a659a7b7b..d8b49ba831 100644 --- a/src/Polly.RateLimiting/RateLimiterResilienceStrategyBuilderExtensions.cs +++ b/src/Polly.RateLimiting/RateLimiterResilienceStrategyBuilderExtensions.cs @@ -98,8 +98,6 @@ public static TBuilder AddRateLimiter( Guard.NotNull(builder); Guard.NotNull(options); - ValidationHelper.ValidateObject(options, "The rate limiter strategy options are invalid."); - builder.AddStrategy(context => new RateLimiterResilienceStrategy(options.RateLimiter!, options.OnRejected, context.Telemetry), options); return builder; } diff --git a/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderTests.cs b/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderTests.cs index 219b05f6d2..ef77a83a16 100644 --- a/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderTests.cs +++ b/test/Polly.Core.Tests/CircuitBreaker/CircuitBreakerResilienceStrategyBuilderTests.cs @@ -61,14 +61,12 @@ public void AddCircuitBreaker_Validation() new ResilienceStrategyBuilder() .Invoking(b => b.AddSimpleCircuitBreaker(new SimpleCircuitBreakerStrategyOptions { BreakDuration = TimeSpan.MinValue })) .Should() - .Throw() - .WithMessage("The circuit breaker strategy options are invalid.*"); + .Throw(); new ResilienceStrategyBuilder() .Invoking(b => b.AddSimpleCircuitBreaker(new SimpleCircuitBreakerStrategyOptions { BreakDuration = TimeSpan.MinValue })) .Should() - .Throw() - .WithMessage("The circuit breaker strategy options are invalid.*"); + .Throw(); } [Fact] @@ -77,14 +75,12 @@ public void AddAdvancedCircuitBreaker_Validation() new ResilienceStrategyBuilder() .Invoking(b => b.AddAdvancedCircuitBreaker(new AdvancedCircuitBreakerStrategyOptions { BreakDuration = TimeSpan.MinValue })) .Should() - .Throw() - .WithMessage("The advanced circuit breaker strategy options are invalid.*"); + .Throw(); new ResilienceStrategyBuilder() .Invoking(b => b.AddAdvancedCircuitBreaker(new AdvancedCircuitBreakerStrategyOptions { BreakDuration = TimeSpan.MinValue })) .Should() - .Throw() - .WithMessage("The advanced circuit breaker strategy options are invalid.*"); + .Throw(); } [Fact] diff --git a/test/Polly.Core.Tests/Fallback/FallbackResilienceStrategyBuilderExtensionsTests.cs b/test/Polly.Core.Tests/Fallback/FallbackResilienceStrategyBuilderExtensionsTests.cs index 445cc45cd4..4807014437 100644 --- a/test/Polly.Core.Tests/Fallback/FallbackResilienceStrategyBuilderExtensionsTests.cs +++ b/test/Polly.Core.Tests/Fallback/FallbackResilienceStrategyBuilderExtensionsTests.cs @@ -56,8 +56,7 @@ public void AddFallback_InvalidOptions_Throws() new ResilienceStrategyBuilder() .Invoking(b => b.AddFallback(new FallbackStrategyOptions())) .Should() - .Throw() - .WithMessage("The fallback strategy options are invalid.*"); + .Throw(); } [Fact] @@ -66,7 +65,6 @@ public void AddFallbackT_InvalidOptions_Throws() new ResilienceStrategyBuilder() .Invoking(b => b.AddFallback(new FallbackStrategyOptions())) .Should() - .Throw() - .WithMessage("The fallback strategy options are invalid.*"); + .Throw(); } } diff --git a/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyBuilderExtensionsTests.cs b/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyBuilderExtensionsTests.cs index baaa9fb1f3..7965b49c73 100644 --- a/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyBuilderExtensionsTests.cs +++ b/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyBuilderExtensionsTests.cs @@ -32,8 +32,7 @@ public void AddHedging_InvalidOptions_Throws() _builder .Invoking(b => b.AddHedging(new HedgingStrategyOptions { HedgingActionGenerator = null! })) .Should() - .Throw() - .WithMessage("The hedging strategy options are invalid.*"); + .Throw(); } [Fact] @@ -42,14 +41,12 @@ public void AddHedgingT_InvalidOptions_Throws() _builder .Invoking(b => b.AddHedging(new HedgingStrategyOptions { MaxHedgedAttempts = 1000 })) .Should() - .Throw() - .WithMessage("The hedging strategy options are invalid.*"); + .Throw(); _genericBuilder .Invoking(b => b.AddHedging(new HedgingStrategyOptions { ShouldHandle = null! })) .Should() - .Throw() - .WithMessage("The hedging strategy options are invalid.*"); + .Throw(); } [Fact] diff --git a/test/Polly.Core.Tests/ResilienceStrategyBuilderTests.cs b/test/Polly.Core.Tests/ResilienceStrategyBuilderTests.cs index 41f753022c..48506ba1bf 100644 --- a/test/Polly.Core.Tests/ResilienceStrategyBuilderTests.cs +++ b/test/Polly.Core.Tests/ResilienceStrategyBuilderTests.cs @@ -181,7 +181,7 @@ public void AddStrategy_InvalidOptions_Throws() .Throw() .WithMessage( """ -The 'ResilienceStrategyOptions' options are not valid. +The 'InvalidResilienceStrategyOptions' are invalid. Validation Errors: The RequiredProperty field is required. diff --git a/test/Polly.Core.Tests/Retry/RetryResilienceStrategyBuilderExtensionsTests.cs b/test/Polly.Core.Tests/Retry/RetryResilienceStrategyBuilderExtensionsTests.cs index 0a33f809fd..bce599a018 100644 --- a/test/Polly.Core.Tests/Retry/RetryResilienceStrategyBuilderExtensionsTests.cs +++ b/test/Polly.Core.Tests/Retry/RetryResilienceStrategyBuilderExtensionsTests.cs @@ -101,13 +101,11 @@ public void AddRetry_InvalidOptions_Throws() new ResilienceStrategyBuilder() .Invoking(b => b.AddRetry(new RetryStrategyOptions { ShouldRetry = null! })) .Should() - .Throw() - .WithMessage("The retry strategy options are invalid.*"); + .Throw(); new ResilienceStrategyBuilder() .Invoking(b => b.AddRetry(new RetryStrategyOptions { ShouldRetry = null! })) .Should() - .Throw() - .WithMessage("The retry strategy options are invalid.*"); + .Throw(); } } diff --git a/test/Polly.Core.Tests/Timeout/TimeoutResilienceStrategyBuilderExtensionsTests.cs b/test/Polly.Core.Tests/Timeout/TimeoutResilienceStrategyBuilderExtensionsTests.cs index 80b62eb982..10e828e290 100644 --- a/test/Polly.Core.Tests/Timeout/TimeoutResilienceStrategyBuilderExtensionsTests.cs +++ b/test/Polly.Core.Tests/Timeout/TimeoutResilienceStrategyBuilderExtensionsTests.cs @@ -51,7 +51,7 @@ public void AddTimeout_InvalidOptions_Throws() new ResilienceStrategyBuilder() .Invoking(b => b.AddTimeout(new TimeoutStrategyOptions { Timeout = TimeSpan.Zero })) .Should() - .Throw().WithMessage("The timeout strategy options are invalid.*"); + .Throw(); } private static TimeSpan GetTimeout(TimeoutResilienceStrategy strategy) diff --git a/test/Polly.Core.Tests/Utils/TypeNameFormatterTests.cs b/test/Polly.Core.Tests/Utils/TypeNameFormatterTests.cs new file mode 100644 index 0000000000..ee91f54bf8 --- /dev/null +++ b/test/Polly.Core.Tests/Utils/TypeNameFormatterTests.cs @@ -0,0 +1,15 @@ +using System.Collections.Generic; +using Polly.Utils; + +namespace Polly.Core.Tests.Utils; + +public class TypeNameFormatterTests +{ + [Fact] + public void AsString_Ok() + { + Polly.Utils.TypeNameFormatter.Format(typeof(string)).Should().Be("String"); + Polly.Utils.TypeNameFormatter.Format(typeof(List)).Should().Be("List"); + Polly.Utils.TypeNameFormatter.Format(typeof(KeyValuePair)).Should().Be("KeyValuePair`2"); + } +} diff --git a/test/Polly.RateLimiting.Tests/RateLimiterResilienceStrategyBuilderExtensionsTests.cs b/test/Polly.RateLimiting.Tests/RateLimiterResilienceStrategyBuilderExtensionsTests.cs index 68c1ab2115..f256d42866 100644 --- a/test/Polly.RateLimiting.Tests/RateLimiterResilienceStrategyBuilderExtensionsTests.cs +++ b/test/Polly.RateLimiting.Tests/RateLimiterResilienceStrategyBuilderExtensionsTests.cs @@ -75,7 +75,7 @@ public void AddRateLimiter_InvalidOptions_Throws() .Should() .Throw() .WithMessage(""" - The rate limiter strategy options are invalid. + The 'RateLimiterStrategyOptions' are invalid. Validation Errors: The RateLimiter field is required. @@ -89,7 +89,7 @@ public void AddGenericRateLimiter_InvalidOptions_Throws() .Should() .Throw() .WithMessage(""" - The rate limiter strategy options are invalid. + The 'RateLimiterStrategyOptions' are invalid. Validation Errors: The RateLimiter field is required.