Any reason OnHalfOpen doesn't take a context?

[rmiller333]

Is your feature request related to a specific problem? Or an existing feature? Please describe.

I'm using a context to pass a logger. Since it's on an httpClient in my case, it's really just a static logger and I should be able to use one. However, I'd like to leverage the infrastructure to use the context to get the logger and reduce statics floating around.

This didn't work since I didn't see an overload that takes a context for onHalfOpen. Is there a reason it doesn't take a context?

return Policy<HttpResponseMessage>
                .HandleResult(r => !r.IsSuccessStatusCode)
                .CircuitBreakerAsync(
                    siftPollySettings.ConsecutiveExceptionsAllowedBeforeBreaking,
                    TimeSpan.FromSeconds(siftPollySettings.DurationOfBreakInSeconds),
                    onBreak: (ex, breakDelay, context) =>
                    {
                        var logger = context.GetLogger();
                        logger.LogMap(LogLevel.Error, "SiftExtensions.AddSift.ExcessiveErrors.PollyBreakingSiftCalls", new Dictionary<string, object>()
                        {
                            { "durationSeconds", siftPollySettings.DurationOfBreakInSeconds },
                            { "ex", ex },
                        });
                    },
                    onReset: (context) =>
                    {
                        var logger = context.GetLogger();
                        logger.LogWarning("SiftExtensions.AddSift.PollyResumingSiftCalls");
                    },
                    onHalfOpen: (context) =>
                    {
                        var logger = context.GetLogger();
                        logger.LogWarning("SiftExtensions.AddSift.PollyTestingResumingSiftCalls");
                    });

Any additional info?

[rmiller3]

I just found this, which describes why. #311 (Mar25-2019 response)

I just have to decide if a static logger is better or no log is better for onHalfOpen.

[SimonCropp]

seems you have resolved this yourself. Will close for now