Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying mount directory to --appimage-mount #981

Open
crass opened this issue Jul 10, 2019 · 5 comments
Open

Allow specifying mount directory to --appimage-mount #981

crass opened this issue Jul 10, 2019 · 5 comments

Comments

@crass
Copy link

crass commented Jul 10, 2019

It would be nice (and more script friendly) to be able to specify a mount directory when using --appimage-mount rather than getting a random directory from mkdtemp.

@probonopd
Copy link
Member

Can you please give a concrete example of what this would help accomplish? In general, we are trying to keep configurability to a bare minimum in order to reduce complexity and support burden by focusing on defaults that work for most people. Is there something you need to do which you currently cannot do?

@probonopd
Copy link
Member

Answering my own question: netblue30/firejail#2690 (comment). Let's keep in mind, though, that this may not be a valid option for Firejail anytime soon since there are lots of pre-existing AppImages out there which don't have this functionality.

@TheAssassin
Copy link
Member

For automation, it'd be nice to be able to choose the mounting directory. Tools like appimagelint which need to inspect the contents of an AppImage have to do some really annoying pipe communication to get the mountpoint directory.

@crass
Copy link
Author

crass commented Jul 10, 2019

Right, I originally wrote this because I was thinking it would be useful for firejail, but now I don't think we'll be doing that. And as you point out, there might not be many appimages that allow that would have this change for a long while, but that's actually an argument for adding this capability as soon as possible for others and potentially firejail down the line if conditions are favorable for going that route later. As pointed out though, I think this is generally useful, mostly for programs interacting with appimages.

I appreciate not wanting to add complexity to, and in general support that. I think in this case complexity added will be minimal because the option is already accepted so parsing out an extra =/some/path and setting the mountdir var to it is pretty trivial. So it seems like a its a moderate win for little cost. And btw, thanks for you guys work on AppImage!

@TheAssassin
Copy link
Member

It's worth implementing in the next runtime version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants