Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Xscreensaver #1909

Closed
wants to merge 1 commit into from
Closed

Create Xscreensaver #1909

wants to merge 1 commit into from

Conversation

bdantas
Copy link

@bdantas bdantas commented Feb 20, 2020

@bdantas bdantas closed this Feb 20, 2020
@probonopd
Copy link
Member

Hi @bdantas how did you make the AppImage?

Possibly you may be running into netblue30/firejail#2690 here.

@bdantas
Copy link
Author

bdantas commented Feb 25, 2020

Hi @bdantas how did you make the AppImage?

Hi @probonopd I made the AppImage this way:

@probonopd
Copy link
Member

Thank you very much for your analysis @bdantas.

@probonopd
Copy link
Member

probonopd commented Feb 27, 2020

Actually, we are already using --noprofile:

firejail --quiet --noprofile --net=none --appimage ./"$FILENAME" &

What gives?

@bdantas bdantas closed this Feb 28, 2020
@bdantas
Copy link
Author

bdantas commented Feb 28, 2020

@probonopd For AppImages that have the "Permission denied" issue, --noprofile cannot be combined with --appimage:

$ firejail --appimage ./Xscreensaver-x86_64.AppImage # doesn't work ("Permission denied")
$ firejail --noprofile ./Xscreensaver-x86_64.AppImage # works
$ firejail --noprofile --appimage ./Xscreensaver-x86_64.AppImage # doesn't work

Firejail contributor glitsj16 could reproduce this. See netblue30/firejail#3249 (comment)

I documented how to fix the "Permission denied" issue here: AppImage/AppImageKit#1032 (comment)

--appimage and --noprofile can be combined after the AppImage has been repaired. However, combining --appimage with a specific profile (e.g., --appimage --profile=/etc/firejail/firefox.profile) is better because it results in a stronger sandbox.

@bdantas bdantas reopened this Feb 28, 2020
@bdantas bdantas closed this Feb 29, 2020
@bdantas bdantas reopened this Feb 29, 2020
@probonopd
Copy link
Member

Thanks for your investigation @bdantas, what do you suggest I should do? Change the automated test to use --noprofile rather than --appimage?

@bdantas
Copy link
Author

bdantas commented Mar 7, 2020

You're welcome, @probonopd. Yes, until this "Permission denied" issue becomes ancient history, I'd use the --noprofile flag without the --appimage flag in the automated system.

@bdantas bdantas closed this Mar 9, 2020
@bdantas bdantas reopened this Mar 9, 2020
@bdantas bdantas closed this Mar 9, 2020
@probonopd
Copy link
Member

Now that we know the reason for the Firejail incompatibility with some AppImages, would it be possible that you please make it so that all directories in your AppImage (including the AppDir itself) are 0755? Once done just ping me here so that I will re-run the test. Then I hope this error disappears. Thank you so very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants