Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaked closable objects #39

Closed
trauzti opened this issue Apr 20, 2015 · 6 comments
Closed

Leaked closable objects #39

trauzti opened this issue Apr 20, 2015 · 6 comments

Comments

@trauzti
Copy link

trauzti commented Apr 20, 2015

My app crashes when I run it with the Appboy SDK in StrictMode with .detectLeakedClosableObjects()
This is the output from logcat:

+E/StrictMode(27538): A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
+E/StrictMode(27538): java.lang.Throwable: Explicit termination method 'end' not called
+E/StrictMode(27538): at dalvik.system.CloseGuard.open(CloseGuard.java:184)
+E/StrictMode(27538): at java.util.zip.Inflater.(Inflater.java:82)
+E/StrictMode(27538): at java.util.zip.GZIPInputStream.(GZIPInputStream.java:103)
+E/StrictMode(27538): at java.util.zip.GZIPInputStream.(GZIPInputStream.java:88)
+E/StrictMode(27538): at bo.app.h.a(SourceFile:72)
+E/StrictMode(27538): at bo.app.h.a(SourceFile:52)
+E/StrictMode(27538): at bo.app.h.a(SourceFile:43)
+E/StrictMode(27538): at bo.app.k.a(SourceFile:36)
+E/StrictMode(27538): at bo.app.j.a(SourceFile:36)
+E/StrictMode(27538): at bo.app.db.run(SourceFile:64)
+E/StrictMode(27538): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
+E/StrictMode(27538): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
+E/StrictMode(27538): at java.lang.Thread.run(Thread.java:818)

@trauzti
Copy link
Author

trauzti commented Apr 20, 2015

I decided to stop using Appboy because of this issue and moved to Fabric and Flurry instead. This is the version of Appboy I was using when I detected this issue: compile 'com.appboy:android-sdk-ui:1.6.+'

@briancaw
Copy link
Contributor

Hi @trauzti

Thanks for reporting this. We have found the cause of this error and have identified a solution that we'll test today. We'll update with an ETA for the release of the fix this afternoon.

@trauzti
Copy link
Author

trauzti commented Apr 20, 2015

Thanks @briancaw

Good for future users of Appboy =)

@briancaw
Copy link
Contributor

Hi again @trauzti

We've got a solution tested and ready to go. We've yet to see any signal this bug's impact is significant beyond the particular scenario you reported (which certainly isn't nothing, but you're the only person who has reported it and you seem to be no longer blocked as you've moved away from using Appboy). So we'll bundle this into our next planned release which will be inside of two weeks.

Thanks again for reporting this, and I hope you eventually give Appboy another try.

@trauzti
Copy link
Author

trauzti commented Apr 21, 2015

Great news @briancaw

Excellent development speed guys. I always run my apps tracking every detail with StrictMode in the development cycle.
This issue was rather annoying because the app kept crashing after a few activities had been opened.

If I return to Appboy I hope that the app will perform well with my setup.

Best wishes,
Trausti

@briancaw
Copy link
Contributor

This is fixed in 1.7.2. Thanks again @trauzti!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants