If the current app can already handle the deep link, default to using it #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catacom
force-pushed
the
deeplink_default
branch
from
58ff775
to
e57d193
Compare
catacom
force-pushed
the
deeplink_default
branch
from
e57d193
to
e29eb35
Compare
|
@catacom Thanks for submitting this PR - it's a great idea. We've just completed qa on our end and will merge shortly. Note that aars with the new deep link handling won't be available in maven until after our next release - you may need to use a forked version until then. Thanks again! We'll shout you out in our next release changelog. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using default link handling, the user is prompted to select the app which should handle the deep link on some devices. IMHO this shouldn't be the case when the current app can handle the deep link already.