Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency links from setup.py #246

Closed
ra-tolson opened this issue Apr 12, 2017 · 3 comments
Closed

remove dependency links from setup.py #246

ra-tolson opened this issue Apr 12, 2017 · 3 comments

Comments

@ra-tolson
Copy link
Collaborator

ra-tolson commented Apr 12, 2017

Stop relying on dependency links in setup.py as this (apparent) misfeature won't be supported by pip --process-dependency-links indefinitely.

@ircwaves
Copy link
Collaborator

There's a bit of confusion around this, but the most recent information that I have regarding --process-dependency-links is here:
pypa/pip#4187

@ra-tolson
Copy link
Collaborator Author

ra-tolson commented Apr 12, 2017

My mistake: It's an apparent misfeature in setuptools but only deprecated in pip; I've edited the top comment accordingly.

I say 'apparent misfeature' because this guy thinks so, and he's evidently a significant contributor to the python packaging landscape; here's the blog post I found earlier and put into another of our packaging issues:

https://caremad.io/posts/2013/07/setup-vs-requirement/ <-- section "A Setuptools Misfeature"

The author of that, by amazing coincidence, wrote the relevant comment here:

pypa/pip#1955 (comment)

That issue, 1955, is the one linked by pypa/pip#4187! 😲

@ircwaves
Copy link
Collaborator

ircwaves commented May 3, 2017

We will only continue to use this misfeature until gippy 0.3.x is updated at the cheese shop OR we migrate to gippy 1.x.

@ircwaves ircwaves closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants