Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native link #1

Closed
Ehesp opened this issue Nov 15, 2016 · 6 comments
Closed

react-native link #1

Ehesp opened this issue Nov 15, 2016 · 6 comments

Comments

@Ehesp
Copy link

Ehesp commented Nov 15, 2016

Hi, would it be possible to add the react-native link CLI to this project?

@af-fess
Copy link
Collaborator

af-fess commented Nov 15, 2016

@Ehesp can you clarify?

@Ehesp
Copy link
Author

Ehesp commented Nov 15, 2016

Sure. Instead of manually setting the iOS /Android workflow which is currently in the readme, it'd be cool if we could just run 'react-native link react-native-appsflyer', this would automatically update all the required files without the need for manual intervention. This is handy when you've got an automated build script for the apps.

If you look at https://github.com/zo0r/react-native-push-notification/blob/master/README.md they do this among many other libs.

Docs;

https://facebook.github.io/react-native/docs/linking-libraries-ios.html

@af-fess
Copy link
Collaborator

af-fess commented Nov 15, 2016

@Ehesp make sense, we will check it out. Thanks,

@jlo1
Copy link

jlo1 commented Jan 18, 2017

Seems like react-native link works fine for android, but breaks for ios?

rnpm-install info Linking react-native-appsflyer android dependency 
rnpm-install info Android module react-native-appsflyer has been successfully linked 
rnpm-install info Linking react-native-appsflyer ios dependency 
rnpm-install ERR! It seems something went wrong while linking. Error: Expected "{" but "/" found. 
Please file an issue here: https://github.com/facebook/react-native/issues 

Might be related to facebook/react-native#10032

@Ehesp
Copy link
Author

Ehesp commented Mar 13, 2017

Also getting this issue.

@af-fess
Copy link
Collaborator

af-fess commented May 16, 2018

$ react-native link react-native-appsflyer
Scanning folders for symlinks in /Users/maxim/Appsflyer/projects/DEMOS/REACT_NATIVE/DemoPod3/node_modules (18ms)
rnpm-install info Linking react-native-appsflyer ios dependency 
rnpm-install info Platform 'ios' module react-native-appsflyer has been successfully linked 
rnpm-install info Linking react-native-appsflyer android dependency 
rnpm-install info Platform 'android' module react-native-appsflyer has been successfully linked 

and unlink:

$ react-native unlink react-native-appsflyer

Scanning folders for symlinks in /Users/maxim/Appsflyer/projects/DEMOS/REACT_NATIVE/DemoPod3/node_modules (13ms)
rnpm-install info Unlinking react-native-appsflyer ios dependency 
rnpm-install info Platform 'ios' module undefined has been successfully unlinked 
rnpm-install info Unlinking react-native-appsflyer android dependency 
rnpm-install info Platform 'android' module undefined has been successfully unlinked 

Env:

react-native-cli: 2.0.1
react-native: 0.55.4

Closed because of non-activity

@af-fess af-fess closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants