Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeGraph IsValid #9

Open
Timmoth opened this issue Dec 3, 2019 · 0 comments
Open

NodeGraph IsValid #9

Timmoth opened this issue Dec 3, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right todo

Comments

@Timmoth
Copy link
Collaborator

Timmoth commented Dec 3, 2019 •
edited
Loading

Determines if the node graph is... well.. valid.
The current approach is very naive and needs lots of work, basically return true if there exists an EndNode which you can reach from the start node.

Improvements:

  1. Is there a path for which the EndNode is impossible to reach? (e.g in point 5)
  2. Do all nodes have valid destination nodes?
  3. Do all nodes have valid Choosers?
  4. Are any exit nodes duplicates within a Node E.G a binary node (A)->(B,B) can just be a unary node (A)->(B).
  5. Do any Unary nodes loop back to themselves? (A)->(A)
  6. Is the start node an EndNode?
@Timmoth Timmoth added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right todo labels Dec 3, 2019
@Timmoth Timmoth changed the title NodeEngine IsValid NodeGraph IsValid Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Timmoth