Change to ES6 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Now targets es6 with the build to hopefully improve tree shaking.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 31 -1
Lines 476 381 -95
Branches 46 45 -1
=========================================
- Hits 476 381 -95
Continue to review full report at Codecov.
|
This commit wont pass tests, this commit was created to give a rollback point whilst fixing esm in jest.
BREAKING CHANGE: this moves package functions which require native node functions to work, which messes up remix etc...
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Breaking Change that finally addresses the issue that this library was not being tree-shaken like you would expect it too. This meant that in a lot of cases it would require modules that are not browser compatible even when you used a function that was.
To solve this I now target es6 and have disabled sideEffects. Initial testing shows that even when importing from
@arcath/utilsyou now only get the functions required for your named imports. This is exactly what I was aiming for.I'm going to look at other issues and updates at the same time to see if I can make one breaking change release and drop them all at once.