Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.13 doesn't respect RepositoryMap.xml content. #55

Closed
denis-anisimov opened this issue May 25, 2017 · 1 comment
Closed

Version 1.0.13 doesn't respect RepositoryMap.xml content. #55

denis-anisimov opened this issue May 25, 2017 · 1 comment

Comments

@denis-anisimov
Copy link

Version 1.0.12 (by the way your Changelog file has incorrect versions, e.g. it refers to 1.13.0 instead of 1.0.13) respects the content of custom RepositoryMap.xml :
I have only chromedriver specified there.
As a result only chromedriver is downloaded.
Version 1.0.13 downloads every windows driver even if it's not specified in the RepositoryMap.xml .

Here is the content of the RepositoryMap.xml :

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<root>
    <windows>
        <driver id="googlechrome">
            <version id="2.29">
                <bitrate thirtytwobit="true" sixtyfourbit="true">
                    <filelocation>http://chromedriver.storage.googleapis.com/2.29/chromedriver_win32.zip
                    </filelocation>
                    <hash>2f02f28d3ff1b8f2a63cb3bc32c26ade60ac4737</hash>
                    <hashtype>sha1</hashtype>
                </bitrate>
            </version>
        </driver>
    </windows>
    <linux>
        <driver id="googlechrome">
            <version id="2.29">
                <bitrate sixtyfourbit="true">
                    <filelocation>http://chromedriver.storage.googleapis.com/2.29/chromedriver_linux64.zip
                    </filelocation>
                    <hash>025a098cde0a6ad8aef53d6734979c9845bf49b5</hash>
                    <hashtype>sha1</hashtype>
                </bitrate>
            </version>
        </driver>
    </linux>
    <osx>
        <driver id="googlechrome">
            <version id="2.29">
                <bitrate thirtytwobit="true" sixtyfourbit="true">
                    <filelocation>http://chromedriver.storage.googleapis.com/2.29/chromedriver_mac64.zip
                    </filelocation>
                    <hash>cec18df4ef736d6712593faf91b462352217214a</hash>
                    <hashtype>sha1</hashtype>
                </bitrate>
            </version>
        </driver>
    </osx>
</root>

Only chrome driver should be downloaded. Nothing else.

@denis-anisimov
Copy link
Author

It looks like the issue is in the plugin config.
The plugin is configured in this way:

<configuration>
    <onlyGetDriversForHostOperatingSystem>true</onlyGetDriversForHostOperatingSystem>
    <rootStandaloneServerDirectory>../driver</rootStandaloneServerDirectory>
    <downloadedZipFileDirectory>../driver_zips</downloadedZipFileDirectory>
    <customRepositoryMap>../drivers.xml</customRepositoryMap>
</configuration>

As a result the content of the drivers.xml (which is in the parent directory) is completely ignored.
That's why it downloads all drivers for the given operation system. It downloads other driver than specified in the drivers.xml.
So it looks like relative reference to the parent folder is the issue.
Paths in the other options works fine (e.g. downloadedZipFileDirectory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant