Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy : System variable instead of Environment variable #65

Closed
sparqueur opened this issue Oct 6, 2017 · 0 comments
Closed

Proxy : System variable instead of Environment variable #65

sparqueur opened this issue Oct 6, 2017 · 0 comments

Comments

@sparqueur
Copy link

sparqueur commented Oct 6, 2017

Hi,

There is either an issue in the documentation or in the code.
Doc says :

To specify an explicit proxy set the environment variables http.proxyHost and http.proxyPort

In DetectProxyConfig.java :

String proxyHost = System.getProperty("http.proxyHost");
Integer proxyPort = Integer.getInteger(System.getProperty("http.proxyPort"));

-> It should be System.getEnv

Maybe you could have both.
I currently have to use a third party maven plugin (properties-maven-plugin) to set this variables.

Regards

@Ardesco Ardesco closed this as completed in f15c873 Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant