Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBUS Output: Channel 5 also being output on Channel 13 #26815

Closed
rmackay9 opened this issue Apr 16, 2024 · 4 comments · Fixed by #26825
Closed

SBUS Output: Channel 5 also being output on Channel 13 #26815

rmackay9 opened this issue Apr 16, 2024 · 4 comments · Fixed by #26825
Labels

Comments

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 16, 2024

In Copter-4.5 (and higher) the SBus output feature (perhaps best described on the wiki here) is outputting the Channel 5 value to Channel 13 as well. There are likely other channels that are being output incorrectly as well.

This bug was reproduced on two daisy-chained CubeOrangePlus autopilots by doing this:

  1. Loaded 4.6.0-dev onto both autopilots, wiped parameters, performed accel, compass and RC calibration
  2. 1st autopilot's parameters were set:
    • BRD_SBUS_OUT = 3 (100hz)
    • SERVO5_FUNCTION = (RCIN6)
  3. 1st autopilot's SBus out was connected to 2nd autopilot's RCIN port
  4. 1st autopilot's RC input port was connected to an RC receiver and the transmitter's tuning knob was used to change the RC 6 input and thus SERVO5's output
    Copter1-ch5-output
  5. When the 1st Copter was running Copter-4.4.4 the 2nd autopilot's RC input correctly shows only channel 5 changing
    Copter2-1st-on-444
  6. When the 1st Copter was running Copter-4.6.0-dev the 2nd autopilot's RC input shows both channel 5 and 13 changing
    Copter2-1st-on-460

BTW, it did not matter what AP version was on the 2nd autopilot which I believe means the issue must be in the output (not the input).

This PR is the most likely candidate but it is NOT the cause (I've tested before and after) #25169

This bug was first reported here on the Copter-4.5 forum

@andyp1per
Copy link
Collaborator

I would think that the most likely candidate as a cause for this are the iomcu changes

@andyp1per
Copy link
Collaborator

Fixed by #26825

@tridge
Copy link
Contributor

tridge commented Apr 17, 2024

this is worth more investigation, a Saleae trace on the sbus out with 4.5.1 would be good, see what the bits actually look like

@tridge
Copy link
Contributor

tridge commented Apr 30, 2024

@rmackay9 the duplication of the lower 8 channels to upper 8 channels is just a read of the reg_direct.pwm values which are next in line in ram. It will not cause a crash, and it will always be that with this bug the upper 8 channels are a copy of the lower 8 channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants