fix: capture anthropic model name from response #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| if model_name := arguments.get("model"): | ||
| yield LLM_MODEL_NAME, model_name | ||
|
|
||
|
|
||
| def _get_llm_model(message: "Message") -> Iterator[Tuple[str, Any]]: |
There was a problem hiding this comment.
little confused by the stuff above, when does one get used and when does the other get used?
There was a problem hiding this comment.
The argument version is always available, but it may have an alias like latest. On the other hand the true value (with the actual version numbers) may not be available if we did not get a response e.g. due to network issues. So here we'll first set the argument value regardless, and then replace it later with the true value from the response when the response arrives.
There was a problem hiding this comment.
i have renamed them for better clarity
axiomofjoy
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the model argument is latest, we should record the actual model name from the response