Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get_current_span helper function for llama-index #1165

Merged
merged 6 commits into from
Dec 12, 2024
Merged

feat: add get_current_span helper function for llama-index #1165

merged 6 commits into from
Dec 12, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Dec 11, 2024 •
edited
Loading

@RogerHYang RogerHYang requested a review from a team as a code owner December 11, 2024 16:19
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 11, 2024
mikeldking
mikeldking approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@RogerHYang RogerHYang merged commit b46931c into main Dec 12, 2024
3 checks passed
@RogerHYang RogerHYang deleted the get-current-span branch December 12, 2024 16:27
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] provide get_current_span functionality for the llama-index instrumentor
2 participants
@RogerHYang @mikeldking