Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(liteLLM): Implemented image support and corresponding tests #900

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat(liteLLM): Implemented image support and corresponding tests #900

merged 4 commits into from
Aug 19, 2024

Conversation

shreyabsridhar
Copy link
Contributor

Resolves #712

  • Implemented image support so that input images render as in below screenshot
    • Implemented corresponding test: test_completion_image_support()
  • Modified existing completion logic for multiple messages to align with other instrumentations
  • Added 2 lines of code to support base64_json images in image generation in additional to http urls
    • Implemented corresponding test: test_image_generation_b64json
Screenshot 2024-08-15 at 10 58 25 AM

@shreyabsridhar shreyabsridhar requested a review from a team as a code owner August 15, 2024 19:41
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 15, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

fjcasti1
fjcasti1 reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@fjcasti1 fjcasti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but have a quick question we can sync on

.../openinference-instrumentation-litellm/src/openinference/instrumentation/litellm/__init__.py Outdated Show resolved Hide resolved
.../openinference-instrumentation-litellm/src/openinference/instrumentation/litellm/__init__.py Show resolved Hide resolved
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 19, 2024
@shreyabsridhar shreyabsridhar merged commit f6d11eb into main Aug 19, 2024
3 checks passed
@shreyabsridhar shreyabsridhar deleted the litellm-image-support branch August 19, 2024 22:07
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjcasti1 fjcasti1 fjcasti1 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[instrumentation-python] litellm support for images
2 participants
@shreyabsridhar @fjcasti1