Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Support for LlamaIndex with Pydantic2 #955

Closed
mikeldking opened this issue Aug 23, 2024 · 2 comments · Fixed by #971
Closed

[bug] Support for LlamaIndex with Pydantic2 #955

mikeldking opened this issue Aug 23, 2024 · 2 comments · Fixed by #971
Assignees
Labels
bug Something isn't working language: python Related to Python integration

Comments

@mikeldking
Copy link
Contributor

LlamaIndex recently shipped with pydantic 2 support which seems to be breaking the instrumentaiton:

File ~/Library/Caches/pypoetry/virtualenvs/llama-index-caVs7DDe-py3.11/lib/python3.11/site-packages/openinference/instrumentation/llama_index/_handler.py:157
    153     FINISHED = auto()
    154     IN_PROGRESS = auto()
--> 157 class _Span(
    158     BaseSpan,
    159     extra="allow",
    160     keep_untouched=(singledispatchmethod, property),
    161 ):
    162     _otel_span: Span = PrivateAttr()
    163     _attributes: Dict[str, AttributeValue] = PrivateAttr()
    ```
    
    Yielding an error
    
    ```
    NameError: Private attributes must not use valid field names; use sunder names, e.g. '_end_time' instead of 'end_time'.
    ```
    
@mikeldking mikeldking added bug Something isn't working triage Issues that require triage labels Aug 23, 2024
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Aug 23, 2024
@mikeldking mikeldking removed the triage Issues that require triage label Aug 23, 2024
@dosubot dosubot bot added the language: python Related to Python integration label Aug 23, 2024
@Pyiner
Copy link

Pyiner commented Aug 26, 2024

I encountered the same problem. I hope it can be fixed as soon as possible. Thanks!

@mikeldking
Copy link
Contributor Author

Thanks @Pyiner - we've marked it as P0 and will get a fix in ASAP!

@RogerHYang RogerHYang moved this from 📘 Todo to 👨‍💻 In progress in phoenix Aug 27, 2024
@RogerHYang RogerHYang assigned axiomofjoy and unassigned RogerHYang Aug 27, 2024
@github-project-automation github-project-automation bot moved this from 👨‍💻 In progress to ✅ Done in phoenix Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language: python Related to Python integration
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants