feat(playground): Support anyOf json schema #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mikeldking
reviewed
Jan 7, 2025
| @@ -5,33 +5,39 @@ import { assertUnreachable } from "@phoenix/typeUtils"; | |||
|
|
|||
| import { JSONLiteral, jsonLiteralSchema } from "./jsonLiteralSchema"; | |||
|
|
|||
| const jsonSchemaPropertiesSchema = z | |||
There was a problem hiding this comment.
Love it, I wonder if it would be good to have a small set of jest tests that makes it easier to grok what's valid and not valid more declaratively. Would help ensure there are no regressions on the schema.
There was a problem hiding this comment.
We are testing this in various places already related to playground as well as phoenix/app/src/schemas/__tests__/toolSchemas.test.ts
mikeldking
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5921