Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] span -> dataset doesn't carry over meaningful metadata #6082

Open
mikeldking opened this issue Jan 16, 2025 · 5 comments · May be fixed by #6163
Open

[BUG] span -> dataset doesn't carry over meaningful metadata #6082

mikeldking opened this issue Jan 16, 2025 · 5 comments · May be fixed by #6163
Assignees
Labels

Comments

@mikeldking
Copy link
Contributor

see

Image
@mikeldking mikeldking added bug Something isn't working triage issues that need triage labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Jan 16, 2025
@axiomofjoy
Copy link
Contributor

Reported by @hamelsmu

@mikeldking mikeldking changed the title [BUG] span -> dataset doesn't carry over meaningful on on the metadata field [BUG] span -> dataset doesn't carry over meaningful metadata Jan 17, 2025
@mikeldking mikeldking added user request priority: high and removed triage issues that need triage labels Jan 17, 2025
@anticorrelator
Copy link
Contributor

@axiomofjoy @mikeldking could i get a little more color on this? what additional info should we see propogated to the metadata? Just the metadata field on the spans themselves?

@mikeldking
Copy link
Contributor Author

@axiomofjoy @mikeldking could i get a little more color on this? what additional info should we see propogated to the metadata? Just the metadata field on the spans themselves?

In general the metadata was supposed to carry all the attributes of the span for use in experimentation.

It also should probably take the key value pairs in the metadata and stuff it at the top level into the metadata block.

Context is that you upload traces with metadata, you export it to a dataset, and you want the same kv pairs to propogate.

@mikeldking
Copy link
Contributor Author

I would expect attributes that looked like

{
   "llm.input_messages....": "..."
   "metadata": "{ 'user': 123 }"
} 

would result in a dataset record with

metadata: { 'user': 123 }

@mikeldking
Copy link
Contributor Author

We should also just dump any arbitrary attribute into metadata.

@anticorrelator anticorrelator moved this from 📘 Todo to 👨‍💻 In progress in phoenix Jan 24, 2025
@anticorrelator anticorrelator moved this from 👨‍💻 In progress to 🔍. Needs Review in phoenix Jan 24, 2025
@anticorrelator anticorrelator linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔍. Needs Review
Development

Successfully merging a pull request may close this issue.

3 participants